Open
Conversation
theaquamarine
force-pushed
the
realtimelogs
branch
from
86134af to
e169f84
Compare
Owner
|
This is a great feature which I want to add, but it have conflicts that I need to resolve and test before I can merge it. Conflicts are a result of me merging your other pull request for cmtrace compatible logfiles. |
Script is mostly using Write-Host, so stick with that.
Also `Write-Information`, but that's not used in the script and is commented out, to avoid PowerShell version support issues. A proxy is also crated for `Write-Verbose`, but this should probably be behind some sort of log level flag.
The dump of `$Log` is no longer the first thing written to the logs, so saying 'Client Health Check starting' doesn't make much sense. Also simplifies some redundant logic.
From Process block to Begin block
The parameter's not used anywhere so just causes `$Xml` to be shadowed, and since `$Xml` did not have a default, it's shadowed by `$null`, resulting in strange behaviour from anything within `Out-Logfile`'s scope that expects `$Xml` to be defined and populated with a config file if `Out-Logfile` is called without `-Xml $xml`. Decided to remove the parameter rather than default to `$script:xml` as this seemed the clearer option.
theaquamarine
force-pushed
the
realtimelogs
branch
from
795a4ab to
3851206
Compare
Contributor
Author
|
That should sort all the conflicts, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log script operation in real time to files rather than waiting until the end and logging then (
$Logobject is still written to the log file at the end of the run).Most of the changes in this pr are switching
Write-Outputs forWrite-Hostwhere required.