Skip to content

Comments

Antalya 25.8 - Skip crash report send path when disabled#1438

Merged
strtgbb merged 1 commit intoantalya-25.8from
fix/crash-writer-disabled-antalya-25.8
Feb 20, 2026
Merged

Antalya 25.8 - Skip crash report send path when disabled#1438
strtgbb merged 1 commit intoantalya-25.8from
fix/crash-writer-disabled-antalya-25.8

Conversation

@CarlosFelipeOR
Copy link
Collaborator

Fixes #1437

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

@github-actions
Copy link

Workflow [PR], commit [3c82aea]

@CarlosFelipeOR
Copy link
Collaborator Author

QA Verification

Tested the fix by sending kill -SEGV to the server process and checking the crash logs.

Before fix (PR #1387)

The crash handler attempts to send the report and throws a BAD_ARGUMENTS exception due to the empty endpoint:

<Information> CrashWriter: Sending crash report
<Information> CrashWriter: Cannot send a crash report: Code: 36. DB::Exception: Empty protocol in the URL. (BAD_ARGUMENTS)

After fix (this PR)

Version: 25.8.16.20001.altinityantalya

The crash log shows the standard signal handling output with no CrashWriter activity at all:

2026.02.20 18:35:52.823928 [ 2377910 ] {} <Trace> BaseDaemon: Received signal 11
2026.02.20 18:35:52.824021 [ 2377910 ] {} <Fatal> BaseDaemon: ########## Short fault info ############
2026.02.20 18:35:52.824038 [ 2377910 ] {} <Fatal> BaseDaemon: (version 25.8.16.20001.altinityantalya, build id: 6FA7FC38FA897E6DA8734F7A2B6C85FEC76A475A, git hash: 2a4ea1369360e1941255b545c05a6cc1e46d4ee3, architecture: x86_64) (from thread 2377876) Received signal 11
2026.02.20 18:35:52.824043 [ 2377910 ] {} <Fatal> BaseDaemon: Signal description: Segmentation fault

No CrashWriter: Sending crash report or CrashWriter: Cannot send a crash report lines in the log.

Result

The CrashWriter instance is no longer created when crash reporting is disabled, so the send path is fully skipped. No exception, no misleading log noise.

Fixes #1437

@strtgbb strtgbb merged commit 027f871 into antalya-25.8 Feb 20, 2026
445 of 452 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CrashWriter throws BAD_ARGUMENTS exception during crash when crash reporting is disabled

2 participants