Skip to content

[PWGHF] Z: Add eta and dE/dx axes. Add electron momentum correction factor.#12303

Merged
vkucera merged 21 commits intoAliceO2Group:masterfrom
sashingo:master
Aug 1, 2025
Merged

[PWGHF] Z: Add eta and dE/dx axes. Add electron momentum correction factor.#12303
vkucera merged 21 commits intoAliceO2Group:masterfrom
sashingo:master

Conversation

@sashingo
Copy link
Contributor

@sashingo sashingo commented Jul 29, 2025 •
edited
Loading

  • included eta and dE/dx to electron THnSparce to check eID
  • added a parameter to correct momentum to Z mass calculation

@sashingo sashingo closed this Jul 29, 2025
@sashingo sashingo reopened this Jul 29, 2025
@sashingo
Copy link
Contributor Author

sashingo commented Jul 29, 2025

Hi Vit, master branch updated and reopen the request.
Does it work ?

@vkucera
Copy link
Collaborator

vkucera commented Jul 29, 2025

Hi Vit, master branch updated and reopen the request. Does it work ?

The PR has 18 commits now. Not a big deal for now but it is easier to follow the PR updates if the PR commits are just the actual code changes.

@vkucera
Copy link
Collaborator

vkucera commented Jul 29, 2025

Please make the PR title more informative.

@sashingo
Copy link
Contributor Author

sashingo commented Jul 29, 2025

I don't know how to change the PR title.
Do I need to close the pull request and push again by adding the more info in the title ?

@vkucera
Copy link
Collaborator

vkucera commented Jul 29, 2025

I don't know how to change the PR title. Do I need to close the pull request and push again by adding the more info in the title ?

Just press the "Edit" button on the right.

@sashingo
Copy link
Contributor Author

sashingo commented Jul 29, 2025

thanks.
I added more information in title now

@vkucera
Copy link
Collaborator

vkucera commented Jul 29, 2025

You did not change the title. You changed the description.

@sashingo sashingo changed the title [PWGHF] updated to check eID [PWGHF] added eta and dE/dx in THnSpare for electrons and a parameter to correct momentum to Z mass calculation Jul 29, 2025
@sashingo
Copy link
Contributor Author

sashingo commented Jul 29, 2025

ok, I see.
Now the title was changed, too

vkucera
vkucera reviewed Jul 29, 2025
View reviewed changes
@vkucera vkucera marked this pull request as draft July 30, 2025 09:01
@sashingo
Update taskElectronWeakBoson.cxx
f80040b 
- change the parameter name 
-- ptZeeCorrfac => correctionPtElectron
- fixed a typo
@vkucera vkucera changed the title [PWGHF] added eta and dE/dx in THnSpare for electrons and a parameter to correct momentum to Z mass calculation [PWGHF] Add eta and dE/dx in THnSpare for electrons and a parameter to correct momentum to Z mass calculation Jul 30, 2025
@vkucera vkucera changed the title [PWGHF] Add eta and dE/dx in THnSpare for electrons and a parameter to correct momentum to Z mass calculation [PWGHF] Add eta and dE/dx axes. Add electron momentum correction factor. Jul 30, 2025
@vkucera vkucera changed the title [PWGHF] Add eta and dE/dx axes. Add electron momentum correction factor. [PWGHF] Z: Add eta and dE/dx axes. Add electron momentum correction factor. Jul 30, 2025
@sashingo
Copy link
Contributor Author

sashingo commented Jul 31, 2025

Hi Vit,
I think we converged the modification of the task.
If so, please approve and merge when you have time.
thanks in advance !

@vkucera
Copy link
Collaborator

vkucera commented Jul 31, 2025

Thanks @sashingo !

@vkucera vkucera marked this pull request as ready for review July 31, 2025 12:43
@vkucera
Copy link
Collaborator

vkucera commented Jul 31, 2025

Usually, I would wait for the approval of the coordinators but this PR seems trivial enough to merge directly.

@vkucera vkucera enabled auto-merge (squash) July 31, 2025 13:09
@vkucera vkucera merged commit c9cbe27 into AliceO2Group:master Aug 1, 2025
20 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Aug 12, 2025
@sashingo @jpxrk
[PWGHF] Z: Add eta and dE/dx axes. Add electron momentum correction f…
51fa8b6 
…actor. (AliceO2Group#12303)
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@sashingo @jloemker
[PWGHF] Z: Add eta and dE/dx axes. Add electron momentum correction f…
1e48b84 
…actor. (AliceO2Group#12303)
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@sashingo
[PWGHF] Z: Add eta and dE/dx axes. Add electron momentum correction f…
ba1ee9e 
…actor. (AliceO2Group#12303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sashingo @vkucera