[PWGCF] Adding selection on V0 rapidity in cf correlation#12210
[PWGCF] Adding selection on V0 rapidity in cf correlation#12210victor-gonzalez merged 4 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 6 errors, |
Please consider the following formatting changes to AliceO2Group#12210
stefanopolitano
changed the title
stefanopolitano
requested review from
alibuild,
ariedel-cern,
glromane,
jgrosseo,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
I would suggest following linter recommendations specially the one regarding prefixing with std::
abs alone is an error
|
Hi @victor-gonzalez ! Thanks for your comment, I implemented the suggestion from the linter regarding this PR. Let me know if there are further comments/suggestions |
| if (cfgDecayParticleMask != 0 && (cfgDecayParticleMask & (1u << static_cast<uint32_t>(track1.decay()))) == 0u) { | ||
| continue; // skip particles that do not match the decay mask | ||
| } | ||
| if (cfgV0RapidityMax > 0 && std::abs(getV0Rapidity(track1)) > cfgV0RapidityMax) { |
There was a problem hiding this comment.
Hi @stefanopolitano, I think this line is buggy, because for unidentified types it returns -999, but your abs makes it always larger than your default cfgV0RapidityMax, which is 0.8 by default. This rejects all D0s, for example. Perhaps the default should be negative?
There was a problem hiding this comment.
Hi @jaelpark! Indeed, this cut was not ment for D0s since the rapidity cut is typically applied at the skimming/task level, but only for LF V0s. I can change the default value to avoid misunderstanding, although one can always set the configuration value to 0 to switch the selection off
There was a problem hiding this comment.
Thanks. I think we shouldn't let new users of the D0 code be confused why everything is rejected. Another option is to return two values (std::tuple<float, bool>) from getV0Rapidity to indicate with a bool whether the selection applies.
…up#12210) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…up#12210) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…up#12210) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
4 participants
This PR adds the possibility to select the rapidity range of V0s in the correlation function