Skip to content

[Trigger] Zorro: Fix various C++ issues#12019

Merged
mpuccio merged 1 commit intoAliceO2Group:masterfrom
vkucera:zorro
Jul 11, 2025
Merged

[Trigger] Zorro: Fix various C++ issues#12019
mpuccio merged 1 commit intoAliceO2Group:masterfrom
vkucera:zorro

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Jul 11, 2025

  • Member variable ... is not initialized in the constructor. (cppcheck)
  • Function parameter ... should be passed by const reference. (cppcheck)
  • Searching before insertion is not necessary. Use try_emplace instead. (cppcheck)
  • Use static_cast instead of deprecated casting style. (cpplint)
  • IWYU (clang-tidy)
  • Include external headers with <>. (manual)
  • Sort includes. (clang-format)
  • Replace size_t with std::size_t.
  • Use const& to iterate std::vector<ZorroHelper>. (O2 linter)

@github-actions github-actions bot changed the title Zorro: Fix various C++ issues [Trigger] Zorro: Fix various C++ issues Jul 11, 2025
@github-actions
Copy link

github-actions bot commented Jul 11, 2025

O2 linter results: ❌ 21 errors, ⚠️ 0 warnings, 🔕 0 disabled

@vkucera vkucera marked this pull request as ready for review July 11, 2025 12:51
@mpuccio
Copy link
Collaborator

mpuccio commented Jul 11, 2025

Have you checked that there is no functional change? If so, we can merge

@vkucera
Copy link
Collaborator Author

vkucera commented Jul 11, 2025

Have you checked that there is no functional change? If so, we can merge

Yes

@mpuccio mpuccio enabled auto-merge (squash) July 11, 2025 16:45
@mpuccio mpuccio merged commit 2cdec0f into AliceO2Group:master Jul 11, 2025
18 of 19 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@vkucera vkucera deleted the zorro branch January 9, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants