[PWGCF] Request to pull the needed code for hyperloop#11773
Closed
CyF1rmiana wants to merge 12 commits intoAliceO2Group:masterfrom
CyF1rmiana:master
Closed
[PWGCF] Request to pull the needed code for hyperloop#11773CyF1rmiana wants to merge 12 commits intoAliceO2Group:masterfrom CyF1rmiana:master
CyF1rmiana wants to merge 12 commits intoAliceO2Group:masterfrom
CyF1rmiana:master
Conversation
|
O2 linter results: ❌ 1 errors, |
Please consider the following formatting changes to #11773
shouqiye
approved these changes
Jun 27, 2025
victor-gonzalez
requested changes
Jun 27, 2025
Collaborator
victor-gonzalez
left a comment
There was a problem hiding this comment.
Thanks for moving forward this analysis!!
There are a few things that need to be addressed
- the header of the PR is meaningless. Could you please use instead something that reflects the functionality added?
- the source file/task name is ambiguous. Could you please use instead
corrections? Justcorrecan be interpreted as correlations
Additionally, have you considered using the centralized Q vector production? They are produced from several detectors, several harmonics and they are corrected in different steps for different datasets. This is just a suggestion in case you want to consider it
Collaborator
Collaborator
|
And, please, never push code that has not been compiled and tested locally before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding files for q2 calculation in PbPb_pass5.