Skip to content

[PWGHF] Dstar spin alignment in PbPb#11767

Merged
vkucera merged 35 commits intoAliceO2Group:masterfrom
Mingze129:DstarInPbPb
Jul 2, 2025
Merged

[PWGHF] Dstar spin alignment in PbPb#11767
vkucera merged 35 commits intoAliceO2Group:masterfrom
Mingze129:DstarInPbPb

Conversation

@Mingze129
Copy link
Contributor

@Mingze129 Mingze129 commented Jun 25, 2025

Adding new process for Dstar spin alignment analysis in PbPb to CharmPolarisation task.

@github-actions github-actions bot added the pwghf PWG-HF label Jun 25, 2025
@github-actions
Copy link

github-actions bot commented Jun 25, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 5 disabled

@github-actions github-actions bot changed the title Dstar spin alignment in PbPb [PWGHF] Dstar spin alignment in PbPb Jun 25, 2025
@alibuild alibuild mentioned this pull request Jun 25, 2025
Merged
Mingze129 added a commit to Mingze129/O2Physics that referenced this pull request Jun 25, 2025
@Mingze129
Merge pull request #7 from alibuild/alibot-cleanup-11767
63b929e 
Please consider the following formatting changes to AliceO2Group#11767
fgrosa
fgrosa requested changes Jun 25, 2025
View reviewed changes
Copy link
Collaborator

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mingze129 thanks a lot for the development! The general implementation is good, but there are a couple of things to fix, see my comments below

@vkucera vkucera marked this pull request as draft June 26, 2025 09:21
@alibuild alibuild mentioned this pull request Jun 27, 2025
Merged
@vkucera vkucera marked this pull request as draft July 1, 2025 13:44
@vkucera
Copy link
Collaborator

vkucera commented Jul 1, 2025

Thanks for the fixes but you only made local changes. This will not compile. You have to propagate the changes to the rest of the code.
Please do not mark the PR as ready for review until we converge to a final version.

vkucera
vkucera requested changes Jul 1, 2025
View reviewed changes
@Mingze129
Copy link
Contributor Author

Mingze129 commented Jul 1, 2025 •
edited
Loading

Thanks for the fixes but you only made local changes. This will not compile. You have to propagate the changes to the rest of the code. Please do not mark the PR as ready for review until we converge to a final version.

I am really sorry I missed this. It should be fixed now.
I will let you decide whether the PR are ready for review.

@Mingze129 Mingze129 requested a review from vkucera July 1, 2025 14:13
@alibuild alibuild mentioned this pull request Jul 1, 2025
Merged
@alibuild alibuild mentioned this pull request Jul 2, 2025
Merged
@vkucera vkucera marked this pull request as ready for review July 2, 2025 12:28
@vkucera vkucera enabled auto-merge (squash) July 2, 2025 12:29
@vkucera vkucera merged commit e02f651 into AliceO2Group:master Jul 2, 2025
13 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
@Mingze129 @jpxrk
[PWGHF] Dstar spin alignment in PbPb (AliceO2Group#11767)
6a4ba7b
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
@Mingze129
[PWGHF] Dstar spin alignment in PbPb (AliceO2Group#11767)
223f323
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
@Mingze129
[PWGHF] Dstar spin alignment in PbPb (AliceO2Group#11767)
5969613
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
@Mingze129 @vojmach
[PWGHF] Dstar spin alignment in PbPb (AliceO2Group#11767)
439b3c6
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@Mingze129 @jloemker
[PWGHF] Dstar spin alignment in PbPb (AliceO2Group#11767)
6570311
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@Mingze129
[PWGHF] Dstar spin alignment in PbPb (AliceO2Group#11767)
a3fab03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@fgrosa fgrosa fgrosa left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mingze129 @vkucera @fgrosa @alibuild