[PWGLF] removed unnecessary disable directives for o2linter#11600
Closed
alcaliva wants to merge 1 commit intoAliceO2Group:masterfrom
Closed
[PWGLF] removed unnecessary disable directives for o2linter#11600alcaliva wants to merge 1 commit intoAliceO2Group:masterfrom
alcaliva wants to merge 1 commit intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 27 errors, |
Collaborator
|
Thanks @alcaliva |
romainschotter
previously approved these changes
Jun 13, 2025
Collaborator
|
Error while checking build/O2Physics/o2 for 649659d at 2025-06-13 22:51: Full log here. |
Collaborator
@hahassan7 This seems like a bug in |
Collaborator
Author
|
Hi @vkucera, I agree, because that function cannot (and does not) modify the jet, so it should not take a non-const ref. |
auto-merge was automatically disabled
June 14, 2025 06:24
Pull request was closed
Collaborator
Collaborator
Author
|
I decided to close it because the new PR was "hiding" behind this one and I wanted it to be more visible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vkucera, I fixed the issue you mentioned in the previous PR here