[PWGJE] Add photon-hadron correlation analysis task by jkinner2 · Pull Request #11433 · AliceO2Group/O2Physics

jkinner2 · 2025-06-02T08:35:42Z

Adding task for analysing angular photon-jet correlations in data (PWG-JE JP PAG presentation: https://indico.cern.ch/event/1546154/#22-photon-hadron-correlations)

github-actions · 2025-06-02T08:35:59Z

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

jkinner2 · 2025-06-02T13:59:22Z

The failed O2 linter check seems to stem only from other workflows in PWGJE/Tasks/CMakeLists.txt

nzardosh

Thanks for the work and welcome to analysis on O2 :) I have left a very short guiding review, however you can wait for a more detailed review from the EMCal side by @fjonasALICE . For now the main issues I spot is the way the JE derived tables are interfaced with the non-JE tables and also that it seems in more places JE tables could be used. Thanks

nzardosh · 2025-06-02T14:36:10Z

PWGJE/Tasks/photonChargedTriggerCorrelation.cxx

+  PROCESS_SWITCH(CorrelationTableProducer, processRecoCollisionTrigger, "process correlation collision_extra and trigger table (reconstructed)", false);
+
+  void processRecoPipmTPCTOF(aod::JetCollision const& collision,
+                             soa::Join<aod::JetTracks, aod::TracksExtra, aod::TrackSelection, aod::pidTPCPi, aod::pidTOFPi> const& tracks)


The JetTracks table is not joinable by default to the other Track tables. You need to link them through the JTracksPI table as shown in the jettutorial task

I have adjusted the task in the commit "PR_adjustments"

nzardosh · 2025-06-02T14:36:41Z

PWGJE/Tasks/photonChargedTriggerCorrelation.cxx

+    // hadron/pipm
+    for (auto const& track : tracks) {
+      // track selection
+      if (!checkGlobalTrackEta(track))


you can use the track selections implemented in the JE framework

Adjusted in the commit "PR_adjustments"

nzardosh · 2025-06-02T14:37:52Z

PWGJE/Tasks/photonChargedTriggerCorrelation.cxx

+      return;
+
+    // photonsPCM (for some reason collsionId not an index column (?))
+    auto const v0PhotonsThisEvent = v0Photons.sliceBy(perColV0Photons, collision.collision().globalIndex());


instead of collision.collision().globalIndex() you can do collision.collisionId()

Adjusted in the commit "PR_adjustments"

nzardosh · 2025-06-02T14:39:22Z

PWGJE/Tasks/photonChargedTriggerCorrelation.cxx

+    auto const v0PhotonsThisEvent = v0Photons.sliceBy(perColV0Photons, collision.collision().globalIndex());
+
+    // photonPCM
+    for (auto const& v0Photon : v0PhotonsThisEvent) {


where are the v0Photons produced?I guess these are objects from LF. @fjonasALICE do we expect to use these or do we have our own photon/JCluster tables that can be used here instead?

these are not emcal and i am no expert for the V0 in O2

Reply in the original comment below

nzardosh · 2025-06-02T14:40:53Z

PWGJE/Tasks/photonChargedTriggerCorrelation.cxx

+  }
+  PROCESS_SWITCH(PhotonChargedTriggerCorrelation, processCorrFirst, "process to gather info before correlation processes", false);
+
+  void processCorrHadron(CorrCollision const& collision, aod::Triggers const& triggers, aod::Hadrons const& hadrons)


Is this trying to use triggered data? If so please use the JE methods and tables for this

As explained in the original comment, the task is not built for running on triggered data, so I would not know what tables to include. The only software-trigger-related part of the code is an addition in the event selection (used for a test and disabled by default) via "triggerMaskBits" (as in the jetTutorial task).

jkinner2 · 2025-06-03T07:53:07Z

Hello, thank you for the quick response. I have adjusted the task.
Regarding your questions:
The V0PhotonsKF table is produced by the EM task photon-conversion-builder for PCM photons. My task currently does not use the EMCal.
The Triggers table only refers to tracks above some pt threshold. The task runs on minimum bias data (possibly on triggered data in the future).

jkinner2 · 2025-06-25T13:30:33Z

@nzardosh @fjonasALICE
It has been about two weeks since the last update on this PR. I am following up in case this was missed or if there is any further feedback or anything else needed from my side

fjonasALICE

Hi
@nzardosh since no emcal is used I can't comment a lot on the V0. I went through the code for a few general comments. For detailled review the number of changes is too large, but if the code is tested, and given it does not touch anything else, I think it is fine to approve once the requested changes are in. I also did not see if @jkinner2 implemented the changes for the JE software triggers, and one should double check that the V0 candidates can be properly matched to the index of JCollisions

fjonasALICE · 2025-07-01T11:39:29Z

PWGJE/Tasks/photonChargedTriggerCorrelation.cxx

+    auto const v0PhotonsThisEvent = v0Photons.sliceBy(perColV0Photons, collision.collision().globalIndex());
+
+    // photonPCM
+    for (auto const& v0Photon : v0PhotonsThisEvent) {


these are not emcal and i am no expert for the V0 in O2

fjonasALICE · 2025-07-01T11:42:59Z

PWGJE/Tasks/photonChargedTriggerCorrelation.cxx

+/// Also contains checks and monte-carlo (efficiency, purity, mc-true correlation,...)
+/// End goal of studying correlations between direct photons and jets
+
+#define ETA_MAX_DEFAULT 0.8


do we really need to define like this? I think a const double etc in the current namespace would be the better idea

I have implemented it in the commit "change_define_to_variable__move_table_definitions_to_own_header"

fjonasALICE · 2025-07-01T11:43:24Z

PWGJE/Tasks/photonChargedTriggerCorrelation.cxx

+// derived data for correlations (on-the-fly)
+// should be more efficient due to usage in correlations and event mixing
+
+namespace o2::aod


I would propose to move table definitions to their own header file, like it is done for other analysis task

I have adjusted the task in the commit "change_define_to_variable__move_table_definitions_to_own_header"

jkinner2 · 2025-07-01T16:47:44Z

@nzardosh @fjonasALICE
Apologies for previously answering in a central comment. I have now replied to the individual conversation threads.
Regarding the V0 candidate matching: The collision matching is done with the JCollisionPIs table, similar to the track-linking for the PID task. From my tests of the task, I am confident that the V0s are matched correctly.
Please let me know if there are any further changes that need to be made

jkinner2 added 3 commits May 27, 2025 09:06

add_task

8f74df4

addPi0Eff

816bbb0

remove_comments

a19884f

github-actions bot added the pwgje label Jun 2, 2025

github-actions bot changed the title ~~Add photon-hadron correlation analysis task~~ [PWGJE] Add photon-hadron correlation analysis task Jun 2, 2025

alibuild mentioned this pull request Jun 2, 2025

Please consider the following formatting changes to #11433 jkinner2/O2Physics#1

Closed

jkinner2 added 3 commits June 2, 2025 13:42

MegaLinter_errors

c735379

MegaLinter_errors2

05d0db3

clang_format

5877373

jkinner2 marked this pull request as ready for review June 2, 2025 13:49

jkinner2 requested review from alibuild, fjonasALICE, maoyx, mfasDa, mhemmer-cern and nzardosh as code owners June 2, 2025 13:49

nzardosh previously approved these changes Jun 2, 2025

View reviewed changes

nzardosh reviewed Jun 2, 2025

View reviewed changes

nzardosh self-requested a review June 2, 2025 14:42

PR_adjustments

84fee90

jkinner2 dismissed nzardosh’s stale review via 84fee90 June 3, 2025 07:49

jkinner2 added 3 commits June 5, 2025 12:34

add_more_detailed_zPv-mult_info

bdcf463

use_double_precision_for_histograms_expected_with_large_content

3fe8909

minor_histogram_(name)_changes

d5cd1a9

fjonasALICE reviewed Jul 1, 2025

View reviewed changes

change_define_to_variable__move_table_definitions_to_own_header

0fb2c17

github-actions bot added the datamodel label Jul 1, 2025

alibuild mentioned this pull request Jul 1, 2025

Please consider the following formatting changes to #11433 jkinner2/O2Physics#2

Closed

clang_formatting

dff7554

nzardosh approved these changes Jul 7, 2025

View reviewed changes

nzardosh enabled auto-merge (squash) July 7, 2025 12:28

nzardosh merged commit 9476b96 into AliceO2Group:master Jul 7, 2025
11 of 13 checks passed

jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025

[PWGJE] Add photon-hadron correlation analysis task (AliceO2Group#11433)

9da974a

prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025

[PWGJE] Add photon-hadron correlation analysis task (AliceO2Group#11433)

94e630e

JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025

[PWGJE] Add photon-hadron correlation analysis task (AliceO2Group#11433)

57e5bc6

vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025

[PWGJE] Add photon-hadron correlation analysis task (AliceO2Group#11433)

ed1a6ea

jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025

[PWGJE] Add photon-hadron correlation analysis task (AliceO2Group#11433)

dd50414

alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025

[PWGJE] Add photon-hadron correlation analysis task (AliceO2Group#11433)

f460a91

Conversation

jkinner2 commented Jun 2, 2025

Uh oh!

github-actions bot commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkinner2 commented Jun 2, 2025

Uh oh!

nzardosh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkinner2 commented Jun 3, 2025

Uh oh!

jkinner2 commented Jun 25, 2025

Uh oh!

fjonasALICE left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkinner2 commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jun 2, 2025 •

edited

Loading

jkinner2 commented Jul 1, 2025 •

edited

Loading