[PWGJE] trackEfficiency: weights in eff. plots, ptHat cuts by aimeric-landou · Pull Request #11220 · AliceO2Group/O2Physics

aimeric-landou · 2025-05-16T08:32:36Z

in trackEfficiency.cxx file:

adds possibillity to use weights in efficiency and purity plots
introduces ptHat cuts in all processes
cleans file

github-actions · 2025-05-16T08:32:53Z

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

vkucera

Fix the errors. You have bugs in the code.

alibuild · 2025-05-16T09:37:08Z

Error while checking build/O2Physics/o2 for f2e355c at 2025-05-16 11:37:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/daily-20250516-0000-local1/include/Framework/HistogramRegistry.h:451:14: error: 'eventWeight' may be used uninitialized [-Werror=maybe-uninitialized]
ninja: build stopped: subcommand failed.

Full log here.

aimeric-landou · 2025-05-16T10:17:59Z

Ah! i'm sorry, I didn't mean to click on this request review

…uts, clean file

aimeric-landou · 2025-05-16T11:04:21Z

This last version should be much better.

aimeric-landou · 2025-05-19T15:44:50Z

Hi @vkucera
is the new version looking good to merge?

vkucera · 2025-05-19T20:11:02Z

Hi @vkucera is the new version looking good to merge?

Hi @aimeric-landou , thanks for the fixes. Can you fix the rest too?

alibuild · 2025-05-20T11:02:29Z

Error while checking build/O2Physics/o2 for 8b28b50 at 2025-05-20 13:02:

No log files found

Full log here.

vkucera · 2025-05-20T11:51:24Z

PWGJE/Tasks/trackEfficiency.cxx

+  int acceptSplitCollisionsCase0 = 0; // acceptSplitCollisions case: only look at mcCollisions that are not split
+  int acceptSplitCollisionsCase2 = 2; // acceptSplitCollisions case: accept split mcCollisions but only look at the first reco collision associated with it


Where are these values defined?

This implementation is not easy to read, understand, use and maintain, because the names do not reflect the meanings of the values and there is not sanity check to validate the input values provided in acceptSplitCollisions.
I recommend to:

replace these with enum with meaningful names,

add a sanity check for acceptSplitCollisions in init which throws a fatal in case of invalid values.

branch the code with if/else if blocks without an else block.

Hi @vkucera
I was away until this morning, I just updated my file to address your comments, I hope everything looks better now.

vkucera · 2025-05-28T16:14:41Z

PWGJE/Tasks/trackEfficiency.cxx

+  enum AcceptSplitCollisionsOptions {
+    nonSplitOnly = 0,
+    splitOkCheckAnyAssocColl,      // 1
+    splitOkCheckFirstAssocCollOnly // 2


Thanks for fixing the enum name. The linter does not check this but the names of the values should also follow the UpperCamelCase convention because they are compile-time constants.

I just pushed a fix for those three variables; I don't understand what theMegaLinter is now complaining about, do you know?

Thanks @aimeric-landou .
The MegaLinter error occurred because your branch is too old. If you merge the latest master in it, the check should run normally.

fixes done

…oup#11220)

aimeric-landou requested review from alibuild, fjonasALICE, maoyx, mfasDa, mhemmer-cern and nzardosh as code owners May 16, 2025 08:32

github-actions bot added the pwgje label May 16, 2025

vkucera previously requested changes May 16, 2025

View reviewed changes

aimeric-landou requested a review from vkucera May 16, 2025 10:17

[PWGJE] trackEfficiency: add weights to eff. plots, introduce ptHat c…

800a210

…uts, clean file

aimeric-landou force-pushed the master branch from ab55bfe to 800a210 Compare May 16, 2025 10:57

aimeric-landou changed the title ~~[PWGJE] trackEfficiency: allow weights to eff. and purity plots~~ [PWGJE] trackEfficiency: weights in eff. plots, ptHat cuts May 16, 2025

final O2linter corrections

31ce0f2

alibuild mentioned this pull request May 20, 2025

[PWGJE] Please consider the following formatting changes to #11220 aimeric-landou/O2Physics#15

Closed

clang fixes

8b28b50

vkucera reviewed May 20, 2025

View reviewed changes

nzardosh previously approved these changes May 21, 2025

View reviewed changes

nzardosh enabled auto-merge (squash) May 21, 2025 19:29

Adding enum for acceptSplitCollisions

20c0a36

auto-merge was automatically disabled May 28, 2025 10:14
Head branch was pushed to by a user without write access

aimeric-landou dismissed nzardosh’s stale review via 20c0a36 May 28, 2025 10:14

aimeric-landou added 2 commits May 28, 2025 12:16

Enum UpperCamelCase

ca1c382

fix else {} to else if {} transition

cf4f765

alibuild mentioned this pull request May 28, 2025

[PWGJE] Please consider the following formatting changes to #11220 aimeric-landou/O2Physics#16

Closed

fix missing }

974a5e0

vkucera reviewed May 28, 2025

View reviewed changes

UpperCamelCase for enum values

95c4e49

nzardosh approved these changes May 30, 2025

View reviewed changes

nzardosh enabled auto-merge (squash) May 30, 2025 10:12

nzardosh merged commit e487ef9 into AliceO2Group:master May 30, 2025
14 of 15 checks passed

jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025

[PWGJE] trackEfficiency: weights in eff. plots, ptHat cuts (AliceO2Gr…

9438e5c

…oup#11220)

hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Jun 11, 2025

[PWGJE] trackEfficiency: weights in eff. plots, ptHat cuts (AliceO2Gr…

75f09f8

…oup#11220)

EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Jun 12, 2025

[PWGJE] trackEfficiency: weights in eff. plots, ptHat cuts (AliceO2Gr…

01fa7e9

…oup#11220)

prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025

[PWGJE] trackEfficiency: weights in eff. plots, ptHat cuts (AliceO2Gr…

a9d88b5

…oup#11220)

ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025

[PWGJE] trackEfficiency: weights in eff. plots, ptHat cuts (AliceO2Gr…

a16d77c

…oup#11220)

smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025

[PWGJE] trackEfficiency: weights in eff. plots, ptHat cuts (AliceO2Gr…

ea823c4

…oup#11220)

ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jul 16, 2025

[PWGJE] trackEfficiency: weights in eff. plots, ptHat cuts (AliceO2Gr…

4f03b1c

…oup#11220)

alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025

[PWGJE] trackEfficiency: weights in eff. plots, ptHat cuts (AliceO2Gr…

641d089

…oup#11220)

jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025

[PWGJE] trackEfficiency: weights in eff. plots, ptHat cuts (AliceO2Gr…

b8525f2

…oup#11220)

		int acceptSplitCollisionsCase0 = 0; // acceptSplitCollisions case: only look at mcCollisions that are not split
		int acceptSplitCollisionsCase2 = 2; // acceptSplitCollisions case: accept split mcCollisions but only look at the first reco collision associated with it

Conversation

aimeric-landou commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera left a comment

Choose a reason for hiding this comment

Uh oh!

alibuild commented May 16, 2025

Uh oh!

aimeric-landou commented May 16, 2025

Uh oh!

aimeric-landou commented May 16, 2025

Uh oh!

aimeric-landou commented May 19, 2025

Uh oh!

vkucera commented May 19, 2025

Uh oh!

alibuild commented May 20, 2025

Uh oh!

vkucera May 20, 2025

Choose a reason for hiding this comment

Uh oh!

vkucera May 22, 2025

Choose a reason for hiding this comment

Uh oh!

aimeric-landou May 28, 2025

Choose a reason for hiding this comment

Uh oh!

vkucera May 28, 2025

Choose a reason for hiding this comment

Uh oh!

aimeric-landou May 29, 2025

Choose a reason for hiding this comment

Uh oh!

vkucera May 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

aimeric-landou commented May 16, 2025 •

edited

Loading

github-actions bot commented May 16, 2025 •

edited

Loading