GPU: Some maintenance, and use <array> for CUDA / ROCm, but not yet for OpenCL#14277
Merged
davidrohr merged 4 commits intoAliceO2Group:devfrom May 16, 2025
Merged
GPU: Some maintenance, and use <array> for CUDA / ROCm, but not yet for OpenCL#14277davidrohr merged 4 commits intoAliceO2Group:devfrom
davidrohr merged 4 commits intoAliceO2Group:devfrom
Conversation
Collaborator
davidrohr
commented
May 15, 2025
- Renames some misleading flags
- Switches CUDA / ROCm to use instead of GPUCommonArray
- Prepare to get rid of GPUCommonTypeTraits and GPUCommonArray once this is possible in OpenCL.
- Contains already some code to use type_traits in OpenCL, which mostly workd, but it turns out pulled in from <type_traits> has typedefs colliding with opencl-c-stdinc.h. Filed a bug report to clang. Let's see. If we are unlucky, these are just incompatible specifications...
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for ca81641 at 2025-05-15 23:30: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.