GPU Standalone benchmark can compile with ONNX + couple of related fixes#14214
Merged
davidrohr merged 3 commits intoAliceO2Group:devfrom Apr 22, 2025
Merged
GPU Standalone benchmark can compile with ONNX + couple of related fixes#14214davidrohr merged 3 commits intoAliceO2Group:devfrom
davidrohr merged 3 commits intoAliceO2Group:devfrom
Conversation
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
07a22ca to
e25f151
Compare
Collaborator
|
Sure, I'll have a look. Thanks a lot for all the changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ChSonnabend : I checked a bit the ONNXCode. This PR fixes a couple of compiler warnings due to signed vs unsigned comparisons, shadowed variables, unchecked function call results.
Also, I think the CUDA ORT code did never work, and it is actually not compiled in the CI, since we have only the ONNXRuntime for ROCm there.
I fixed the problem that the code used the calls of the OrtApi struct directly, without getting the OrtApi first.
This is fixed now, but now it fails for me since OrtCUDAProviderOptionsV2 is not defined, and I couldn't easily find out what is wrong.
Could you check the ORT CUDA code?
Also, I saw a lot of
int/uintin the NN Clusterizer code, while the GPU code should only use int32_t / uint32_t. Could you change that?Also, the member variables names of the NN Clusterizer do not follow the naming convention: https://rawgit.com/AliceO2Group/CodingGuidelines/master/naming_formatting.html
Could you adapt that as well?