FIT: Geometry alignment macros by andreasmolander · Pull Request #14093 · AliceO2Group/AliceO2

andreasmolander · 2025-03-20T08:49:41Z

Make misalignment macros usable for creating exact misalignments
Add macro for reading misalignments from CCDB
Add a couple of plots to hit reading marcos (needed to verify misalignments)
Minor change to FV0 geometry to provoding symbolic names of alignable volumes

github-actions · 2025-03-20T08:50:36Z

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

afurs · 2025-03-20T08:55:15Z

@andreasmolander I guess you already tested sim after changes in FV0's Detector and Geometry code, right? P.S. I'm not sure if we have sim tests in CI/CD, thats why I'm asking

alibuild · 2025-03-20T09:41:16Z

Error while checking build/O2/fullCI_slc9 for 4f4b54f at 2025-03-20 10:41:

## sw/BUILD/O2-latest/log
CMake Error at Detectors/FIT/macros/CMakeLists.txt:43:
CMake Error at cmake/O2ReportNonTestedMacros.cmake:89 (message):

Full log here.

- Make misalignment macros usable for creating exact misalignments - Add macro for reading misalignments from CCDB - Add a couple of plots to hit reading marcos (needed to verify misalignments) - Minor change to FV0 geometry to provoding symbolic names of alignable volumes

andreasmolander · 2025-03-20T10:20:54Z

@andreasmolander I guess you already tested sim after changes in FV0's Detector and Geometry code, right? P.S. I'm not sure if we have sim tests in CI/CD, thats why I'm asking

@afurs yes

alibuild · 2025-03-27T20:56:34Z

Error while checking build/O2/fullCI_slc9 for fa4d34a at 2025-03-28 01:28:

## sw/BUILD/ONNXRuntime-latest/log
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:26:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:47:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:79:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:155:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:186:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:269:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:314:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:351:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:392:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:433:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:474:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:511:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:548:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:66:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:111:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:167:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:174:12: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:178:12: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:181:17: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:184:17: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:196:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.h:50:18: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.h:50:18: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:2904:46: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3012:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3067:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3130:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3177:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3222:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3284:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3362:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3422:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3481:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3558:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3607:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
ninja: build stopped: subcommand failed.

Full log here.

afurs · 2025-03-28T06:52:17Z

Looks like unrelated CICD issues. @shahor02 could you please merge it?

andreasmolander requested review from afurs and jotwinow as code owners March 20, 2025 08:49

afurs previously approved these changes Mar 20, 2025

View reviewed changes

andreasmolander dismissed afurs’s stale review via 482f280 March 20, 2025 10:11

andreasmolander force-pushed the AFIT-28 branch from 4f4b54f to 482f280 Compare March 20, 2025 10:11

alibuild mentioned this pull request Mar 20, 2025

Please consider the following formatting changes to #14093 andreasmolander/AliceO2#12

Closed

andreasmolander force-pushed the AFIT-28 branch from 482f280 to 2db856d Compare March 20, 2025 10:15

andreasmolander force-pushed the AFIT-28 branch from 2db856d to fa4d34a Compare March 20, 2025 10:19

afurs approved these changes Mar 28, 2025

View reviewed changes

afurs enabled auto-merge (squash) March 28, 2025 06:52

shahor02 merged commit 3f679a6 into AliceO2Group:dev Mar 28, 2025
10 of 13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIT: Geometry alignment macros#14093

FIT: Geometry alignment macros#14093
shahor02 merged 1 commit intoAliceO2Group:devfrom
andreasmolander:AFIT-28

andreasmolander commented Mar 20, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

afurs commented Mar 20, 2025 •

edited

Loading

Uh oh!

alibuild commented Mar 20, 2025

Uh oh!

andreasmolander commented Mar 20, 2025

Uh oh!

alibuild commented Mar 27, 2025 •

edited

Loading

Uh oh!

afurs commented Mar 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Conversation

andreasmolander commented Mar 20, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

afurs commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Mar 20, 2025

Uh oh!

andreasmolander commented Mar 20, 2025

Uh oh!

alibuild commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

afurs commented Mar 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

afurs commented Mar 20, 2025 •

edited

Loading

alibuild commented Mar 27, 2025 •

edited

Loading