MCH: add cut random fraction setting for the cases with and without ITS#14028
MCH: add cut random fraction setting for the cases with and without ITS#14028aferrero2707 wants to merge 1 commit intoAliceO2Group:devfrom
Conversation
Two new environment variables are introduced to provide the fraction of rejected MCH events separately for the cases where ITS is either included (CUT_RANDOM_FRACTION_MCH_WITH_ITS) or excluded (CUT_RANDOM_FRACTION_MCH_NO_ITS) from the data taking. The CUT_RANDOM_FRACTION_MCH variable, as well as the two new ones, can still be overridden by setting them explicitly in the shell environment, therefore the changes are backward compatible.
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
| has_detector_reco ITS && [[ $RUNTYPE != "COSMICS" ]] && CONFIG_EXTRA_PROCESS_o2_mch_reco_workflow+="MCHTimeClusterizer.irFramesOnly=true;" | ||
| if has_detector_reco ITS && [[ $RUNTYPE != "COSMICS" ]]; then | ||
| CONFIG_EXTRA_PROCESS_o2_mch_reco_workflow+="MCHTimeClusterizer.irFramesOnly=true;" | ||
| [[ -z ${CUT_RANDOM_FRACTION_MCH:-} ]] && CUT_RANDOM_FRACTION_MCH=${CUT_RANDOM_FRACTION_MCH_WITH_ITS:-} |
There was a problem hiding this comment.
this seems wrong, I assume you want to check if the _ITS variable is not empty?
There was a problem hiding this comment.
Actually not... I want to set CUT_RANDOM_FRACTION_MCH from CUT_RANDOM_FRACTION_MCH_WITH_ITS only if CUT_RANDOM_FRACTION_MCH is not set already.
In other words, I want to be still able to set something like CUT_RANDOM_FRACTION_MCH=0.5 in the extra ENV variables to completely override the defaults.
Does it make sense?
There was a problem hiding this comment.
ok, fine with me.
But please check in both assignments that CUT_RANDOM_FRACTION_MCH_WITH_ITS or CUT_RANDOM_FRACTION_MCH_NO_ITS respectively are set. So we don't access an undefined variable accidentally.
There was a problem hiding this comment.
@davidrohr sorry, I missed your comment... doesn't the :- construct in the variables access guarantee that a default empty value is used if the variable is not defined?
|
Error while checking build/O2/fullCI_slc9 for bc0f70c at 2025-04-10 09:30: Full log here. |
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
3 participants
Two new environment variables are introduced to provide the fraction of rejected MCH events separately for the cases where ITS is either included (CUT_RANDOM_FRACTION_MCH_WITH_ITS) or excluded (CUT_RANDOM_FRACTION_MCH_NO_ITS) from the data taking.
The CUT_RANDOM_FRACTION_MCH variable, as well as the two new ones, can still be overridden by setting them explicitly in the shell environment, therefore the changes are backward compatible.
JIRA ticket: https://its.cern.ch/jira/browse/MCH-18