GPU: More improvements and cleanup by davidrohr · Pull Request #14001 · AliceO2Group/AliceO2

davidrohr · 2025-02-25T09:58:43Z

Most notably:

add TBB special cases for single tasks
add OpenCL special implementation for memblean
check for SPIR-V capabilities of devices before trying to use them

…vices, which do not support SPIR-V

… value

github-actions · 2025-02-25T09:59:00Z

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

alibuild · 2025-02-25T10:57:33Z

Error while checking build/O2/fullCI_slc9 for 84001fa at 2025-02-25 11:57:

## sw/BUILD/O2-latest/log
CMake Error at GPU/GPUTracking/Base/opencl/cmake_install.cmake:69 (file):
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2025-02-25T12:40:01Z

Error while checking build/O2/fullCI for 320becb at 2025-02-25 13:39:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
CMake Error at GPU/GPUTracking/Base/hip/cmake_install.cmake:69 (file):
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2025-02-25T12:51:20Z

Error while checking build/O2/fullCI_slc9 for 320becb at 2025-02-25 13:51:

## sw/BUILD/O2-latest/log
CMake Error at GPU/GPUTracking/Base/hip/cmake_install.cmake:69 (file):
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2025-02-25T15:30:22Z

Error while checking build/O2/fullCI_slc9 for cf894c7 at 2025-02-25 16:30:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-RTC-test-latest/log
/tmp/o2cagpu_rtc_131_1895339035_36.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_49.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_0.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_85.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_42.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
  652 | #include "GPURec/tmp/o2cagpu_rtc_131_1895339035_45.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_48.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_73.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_24.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_61.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_7.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_44.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_88.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_58.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_78.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_67.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_86.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_51.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_6.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
10: fatal error: 'GPUReconstructionHIPDef.h' file not found
:      652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_43.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_91.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_40.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_9.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_131_1895339035_52.hip/tmp/o2cagpu_rtc_131_1895339035_15.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
[0 more errors; see full log]

Full log here.

alibuild · 2025-02-25T17:42:19Z

Error while checking build/O2/fullCI for cf894c7 at 2025-02-25 18:42:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-RTC-test-latest/log
/tmp/o2cagpu_rtc_132_1695655732_15.hip/tmp/o2cagpu_rtc_132_1695655732_70.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_1.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_85.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_39.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_24.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_79.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_80.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_58.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_55.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_63.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_0.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_18.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_31.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_3.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_62.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_6.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_57.hip:652:10:/tmp/o2cagpu_rtc_132_1695655732_16.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
fatal error: 'GPUReconstructionHIPDef.h' file not found/tmp/o2cagpu_rtc_132_1695655732_83.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_43.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_33.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_84.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_82.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_32.hip:652:10: /tmp/o2cagpu_rtc_132_1695655732_64.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_5.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_37.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_73.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_91.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_30.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_67.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_94.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_56.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_88.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_59.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_34.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_89.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_71.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_65.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_72.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_44.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_21.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_17.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
/tmp/o2cagpu_rtc_132_1695655732_4.hip:652:10: fatal error: 'GPUReconstructionHIPDef.h' file not found
[0 more errors; see full log]

Full log here.

alibuild · 2025-02-25T19:47:49Z

Error while checking build/O2/fullCI for 32882ec at 2025-02-25 20:47:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
clang: error: unsupported option '-fno-integrated-objemitter' for target 'spirv64v1.6'
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2025-02-25T19:58:02Z

Error while checking build/O2/fullCI_slc9 for 32882ec at 2025-02-25 20:58:

## sw/BUILD/O2-latest/log
clang: error: unsupported option '-fno-integrated-objemitter' for target 'spirv64v1.6'
ninja: build stopped: subcommand failed.

Full log here.

…elated parts

davidrohr added 5 commits February 25, 2025 10:56

GPU OpenCL: Improve device detection and do not consider platforms/de…

33be683

…vices, which do not support SPIR-V

GPU: runKernel* functions do anyway return always 0, so remove return…

92afdd8

… value

GPU OpenCL: Reorganize OpenCL code and remove obsolete internals header

8c6dee2

GPU: For spawning a single task, no need to go through TBB

5d37dfc

GPU OpenCL: Add specialization for memclean

e7f1bd1

davidrohr force-pushed the PR branch from 84001fa to 320becb Compare February 25, 2025 11:13

davidrohr force-pushed the PR branch from 320becb to cf894c7 Compare February 25, 2025 13:24

davidrohr force-pushed the PR branch from cf894c7 to 32882ec Compare February 25, 2025 19:26

davidrohr added 2 commits February 25, 2025 21:10

GPU: Reorganize some files, split OCL code in kernel and non-kernel r…

b241b90

…elated parts

GPU OpenCL: Add more human readable error codes, shorten code

793a25e

davidrohr force-pushed the PR branch from 32882ec to 793a25e Compare February 25, 2025 20:11

davidrohr merged commit 31aa182 into AliceO2Group:dev Feb 25, 2025
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GPU: More improvements and cleanup#14001

GPU: More improvements and cleanup#14001
davidrohr merged 7 commits intoAliceO2Group:devfrom
davidrohr:PR

davidrohr commented Feb 25, 2025

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

alibuild commented Feb 25, 2025

Uh oh!

alibuild commented Feb 25, 2025

Uh oh!

alibuild commented Feb 25, 2025

Uh oh!

alibuild commented Feb 25, 2025

Uh oh!

alibuild commented Feb 25, 2025

Uh oh!

alibuild commented Feb 25, 2025

Uh oh!

alibuild commented Feb 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

davidrohr commented Feb 25, 2025

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

alibuild commented Feb 25, 2025

Uh oh!

alibuild commented Feb 25, 2025

Uh oh!

alibuild commented Feb 25, 2025

Uh oh!

alibuild commented Feb 25, 2025

Uh oh!

alibuild commented Feb 25, 2025

Uh oh!

alibuild commented Feb 25, 2025

Uh oh!

alibuild commented Feb 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants