You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@miranov25@matthias-kleiner the TPCTimeSeriesSpec was crashing on the reconstruction with AB tracks allowed to use ITS IB layers (thus contributing to the PV). This trivial fix will treat them as regular PV contributors for what concerns DCA to PV but the difference between TPC and ITS tracks will be dummy.
REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")
+async-label <label1>, <label2>, !<label3> ...
This will add <label1> and <label2> and removes <label3>.
The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
Hello @shahor02
The change looks fine. Please go ahead with the pull request. I also want to commit to including the TRD information, so better to merge now. @matthias-kleiner, do you wan to make a test before?
I plan to implement TRD information tomorrow or during the weekend to have it in the next production.
@miranov25 I've already run a test for ~30 TF of 559781 (37kHz) with 100% sampling (--enable-unbinned-root-output --sample-unbinned-tsallis --threads 1 --sampling-factor 1.001), if you want to check, the result is in https://cernbox.cern.ch/s/oVsLiSDKrzSh0Rj
Error while checking build/O2/fullCI_slc9 for 9898e60 at 2025-02-20 15:04:
## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@miranov25 @matthias-kleiner the TPCTimeSeriesSpec was crashing on the reconstruction with AB tracks allowed to use ITS IB layers (thus contributing to the PV). This trivial fix will treat them as regular PV contributors for what concerns DCA to PV but the difference between TPC and ITS tracks will be dummy.