-
-
Notifications
You must be signed in to change notification settings - Fork 317
Add ingredient editor components #3457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+2,225
−798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddecf85 to
62137b4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3457 +/- ##
==========================================
+ Coverage 97.26% 97.35% +0.08%
==========================================
Files 291 308 +17
Lines 7721 8011 +290
==========================================
+ Hits 7510 7799 +289
- Misses 211 212 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
62137b4 to
41da114
Compare
f709612 to
6d20e39
Compare
6d20e39 to
160a095
Compare
5e5a34c to
dabc262
Compare
mamhoff
approved these changes
Jan 5, 2026
Contributor
mamhoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
2bba31c to
3bc4489
Compare
mamhoff
approved these changes
Jan 7, 2026
Some labels and spacings are off. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Instead of rendering partials and having logic splattered across helpers and a decorator that has methods for all ingredients, we now have self contained component classes for each individual ingredient. Deprecates the IngredientsHelper and the IngredientEditor decorator. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
If an extension or app still uses ingredient editor partials we render it but log a deprecation warning. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
This can be used outside of the ingredient editor decorator and simply delegates to the already existing class method.
The generator now creates ViewComponent-based editor components instead of deprecated editor partials.
This allows to replace ingredient editors with Turbo Stream. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Ingredient editor components no longer require element_form to be passed. This enables rendering individual ingredient editors independently, which is useful for Turbo Frame updates.
This fixes an issue with css class label not appearing if it is not yet present. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
3bc4489 to
d1c2bad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Instead of rendering partials and having logic splattered
across helpers and a decorator that has methods for all
ingredients, we now have self contained component classes
for each individual ingredient.
Notable changes
Deprecates the
Alchemy::Admin::IngredientsHelperand theAlchemy::IngredientEditordecorator.Upgrade notes
Custom ingredient editor partials are deprecated - Apps with custom
app/views/alchemy/ingredients/_*_editor.html.erbpartials will see deprecation warnings. Migrate to ViewComponent-based editors by creating a class inheriting fromAlchemy::Ingredients::BaseEditor.Example migration:
Checklist