Skip to content

Fix UNION ALL with subquery in NOT IN clause #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathiasrw merged 5 commits into from
Jan 8, 2026
Merged

Fix UNION ALL with subquery in NOT IN clause #2404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c23f5e7
Initial plan
Copilot Dec 22, 2025
7b83025
Fix UNION ALL with subquery in NOT IN clause
Copilot Jan 4, 2026
c3cf99a
Refactor UNION query handling to use cleaner stack pattern
Copilot Jan 5, 2026
cf77df9
Add comprehensive edge case tests for UNION with subqueries
Copilot Jan 7, 2026
bbbee34
fmt
mathiasrw Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 69 additions & 10 deletions src/alasqlparser.jison
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1128,28 +1128,87 @@ UnionClause

UnionOp
: UNION
{ $$ = {op: 'union'}; }
{
// Save and reset queries for nested SELECT using stack pattern
if(!yy.queriesStack) yy.queriesStack = [];
yy.queriesStack.push(yy.queries || []);
yy.queries = [];
$$ = {op: 'union'};
}
| UNION ALL
{ $$ = {op: 'unionall'}; }
{
if(!yy.queriesStack) yy.queriesStack = [];
yy.queriesStack.push(yy.queries || []);
yy.queries = [];
$$ = {op: 'unionall'};
}
| EXCEPT
{ $$ = {op: 'except'}; }
{
if(!yy.queriesStack) yy.queriesStack = [];
yy.queriesStack.push(yy.queries || []);
yy.queries = [];
$$ = {op: 'except'};
}
| INTERSECT
{ $$ = {op: 'intersect'}; }
{
if(!yy.queriesStack) yy.queriesStack = [];
yy.queriesStack.push(yy.queries || []);
yy.queries = [];
$$ = {op: 'intersect'};
}
| UNION CORRESPONDING
{ $$ = {op: 'union', corresponding: true}; }
{
if(!yy.queriesStack) yy.queriesStack = [];
yy.queriesStack.push(yy.queries || []);
yy.queries = [];
$$ = {op: 'union', corresponding: true};
}
| UNION ALL CORRESPONDING
{ $$ = {op: 'unionall', corresponding: true}; }
{
if(!yy.queriesStack) yy.queriesStack = [];
yy.queriesStack.push(yy.queries || []);
yy.queries = [];
$$ = {op: 'unionall', corresponding: true};
}
| EXCEPT CORRESPONDING
{ $$ = {op: 'except', corresponding: true}; }
{
if(!yy.queriesStack) yy.queriesStack = [];
yy.queriesStack.push(yy.queries || []);
yy.queries = [];
$$ = {op: 'except', corresponding: true};
}
| INTERSECT CORRESPONDING
{ $$ = {op: 'intersect', corresponding: true}; }
{
if(!yy.queriesStack) yy.queriesStack = [];
yy.queriesStack.push(yy.queries || []);
yy.queries = [];
$$ = {op: 'intersect', corresponding: true};
}
;

UnionableSelect
: SelectWithoutOrderOrLimit
{ $$ = $1; }
{
// Restore parent queries from stack and assign current queries to nested SELECT
if(yy.queriesStack && yy.queriesStack.length > 0) {
if(yy.queries && yy.queries.length > 0) {
$1.queries = yy.queries;
}
yy.queries = yy.queriesStack.pop();
}
$$ = $1;
}
| ParenthesizedSelect
{ $$ = $1; }
{
// Restore parent queries from stack and assign current queries to nested SELECT
if(yy.queriesStack && yy.queriesStack.length > 0) {
if(yy.queries && yy.queries.length > 0) {
$1.queries = yy.queries;
}
yy.queries = yy.queriesStack.pop();
}
$$ = $1;
}
;

OrderClause
Expand Down
71 changes: 62 additions & 9 deletions src/alasqlparser.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading