Fix improper parsing of string_view integer and try to validate it better. #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate proper termination and range for index parsing.
Collaborator
|
I think your diagnosis of the problem is correct (good catch), and I believe your code is fine, but I think there may be a simpler solution. Let me take a quick stab at it and see which way you like better. |
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Oct 25, 2017
@marsupial correctly points out that we are unsafely passing a string_view.data() into both atoi and strchr, which is unsafe because there's no guarantee that a string_view is null-terminated. Ugh! He proposed a fix here: AcademySoftwareFoundation#800 and there's nothing wrong with it per se, but I suspected it could be done more simply, so this PR is my stab at it, using the `OIIO::Strutil::parse_*` functions.
Collaborator
|
Counter-proposal presented as #805. Thoughts? |
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Oct 27, 2017
@marsupial correctly points out that we are unsafely passing a string_view.data() into both atoi and strchr, which is unsafe because there's no guarantee that a string_view is null-terminated. Ugh! He proposed a fix here: AcademySoftwareFoundation#800 and there's nothing wrong with it per se, but I suspected it could be done more simply, so this PR is my stab at it, using the `OIIO::Strutil::parse_*` functions.
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Oct 27, 2017
@marsupial correctly points out that we are unsafely passing a string_view.data() into both atoi and strchr, which is unsafe because there's no guarantee that a string_view is null-terminated. Ugh! He proposed a fix here: AcademySoftwareFoundation#800 and there's nothing wrong with it per se, but I suspected it could be done more simply, so this PR is my stab at it, using the `OIIO::Strutil::parse_*` functions.
lgritz
added a commit
that referenced
this pull request
Oct 27, 2017
@marsupial correctly points out that we are unsafely passing a string_view.data() into both atoi and strchr, which is unsafe because there's no guarantee that a string_view is null-terminated. Ugh! He proposed a fix here: #800 and there's nothing wrong with it per se, but I suspected it could be done more simply, so this PR is my stab at it, using the `OIIO::Strutil::parse_*` functions.
Collaborator
|
I merged the counter-proposal of #805, so closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current code is passing string_view::data() to both strchr and atoi, which expect/require null terminated strings.
Tests
Part 1 of 2 which allows connecting individual components of aggregate types.
Second part includes proper test against ShadingSystemImpl::decode_connected_param.
Checklist: