Handle HAVING clause which does not accept alias in filter queries#1028
Open
MlleDelphine wants to merge 2 commits intoAPY:masterfrom
Open
Handle HAVING clause which does not accept alias in filter queries#1028MlleDelphine wants to merge 2 commits intoAPY:masterfrom
MlleDelphine wants to merge 2 commits intoAPY:masterfrom
Conversation
To be up to date
To handle query from filter with necessary HAVING clause which does not accept alias
npotier
requested changes
Apr 1, 2020
Collaborator
npotier
left a comment
npotier
left a comment
There was a problem hiding this comment.
Hello, and thank you for this PR.
Some changes need to be done in order to continue.
| $columnForFilter = (!$column instanceof JoinColumn) ? $column : $columnsById[$filter->getColumnName()]; | ||
|
|
||
| $fieldName = $this->getFieldName($columnForFilter, false); | ||
| $fieldName = $this->getFieldName($columnForFilter, false, $hasHavingClause); |
Collaborator
There was a problem hiding this comment.
if you add a parameter to this function, you should change its signature wich is actually
protected function getFieldName($column, $withAlias = false)
| return "$functionWithParameters as $alias"; | ||
| } | ||
| // To handle query from filter with necessary HAVING clause which does not accept alias | ||
| if (!$withAlias && $hasHaving) { |
Collaborator
There was a problem hiding this comment.
The variable $hasHaving comes from nowhere.
I guess that it should be $hasHavingClause given as parameter of the function ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To handle query from filter with necessary HAVING clause which does not accept alias