-
Notifications
You must be signed in to change notification settings - Fork 144
FIX: tooltip added for navigation icons #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis PR removes sample environment configuration files from both backend and frontend, and adds Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Frontend/src/pages/Collaborations.tsx (1)
64-77: Move title attribute to Link element for consistency.The title attribute is currently on the Button component (line 70), but in the other files in this PR (CollaborationDetails.tsx, Messages.tsx, DashboardPage.tsx), the title is placed directly on the Link element. While Radix UI's
asChildpattern should forward props to the child component, placing the title directly on the Link is more explicit and maintains consistency across the codebase.Apply this diff:
<Button key={to} variant="ghost" size="sm" className="w-9 px-0 hover:bg-[hsl(210,40%,96.1%)] hover:text-[hsl(222.2,47.4%,11.2%)]" asChild - title={label} > - <Link to={to}> + <Link to={to} title={label}> <Icon className="h-5 w-5" /> <span className="sr-only">{label}</span> </Link> </Button>Frontend/src/pages/DashboardPage.tsx (1)
71-73: Simplify JSX expression for title attribute.The title attribute uses an unnecessary JSX expression with quotes:
title={"logout"}. For string literals, you can use the simpler syntaxtitle="logout".Apply this diff:
- <Button onClick={logout} title={"logout"} variant="ghost"> + <Button onClick={logout} title="logout" variant="ghost"> <LogOut className="h-5 w-5" /> </Button>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
Backend/.env-example(0 hunks)Frontend/env-example(0 hunks)Frontend/src/pages/CollaborationDetails.tsx(1 hunks)Frontend/src/pages/Collaborations.tsx(1 hunks)Frontend/src/pages/DashboardPage.tsx(2 hunks)Frontend/src/pages/Messages.tsx(1 hunks)
💤 Files with no reviewable changes (2)
- Frontend/env-example
- Backend/.env-example
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Saahi30
Repo: AOSSIE-Org/InPactAI PR: 98
File: Frontend/src/pages/CollaborationDetails.tsx:234-234
Timestamp: 2025-07-14T11:45:01.864Z
Learning: In frontend-only PRs, hardcoded URLs (like dummy PDF URLs for contracts) and mock data are acceptable and intentional placeholders for UI development, to be replaced during backend integration phase.
🔇 Additional comments (3)
Frontend/src/pages/CollaborationDetails.tsx (1)
333-345: LGTM! Tooltip implementation is correct.The title attribute is properly placed on the Link element, which will provide native browser tooltips on hover. This implementation is consistent with the pattern used in Messages.tsx and DashboardPage.tsx.
Frontend/src/pages/Messages.tsx (1)
208-220: LGTM! Tooltip implementation is correct.The title attribute is properly placed on the Link element, providing native browser tooltips for the navigation icons. This implementation is consistent with the accessibility improvements across the PR.
Frontend/src/pages/DashboardPage.tsx (1)
47-59: LGTM! Tooltip implementation is correct.The title attribute is properly placed on the Link element, providing native browser tooltips for the navigation icons. This follows the consistent pattern used across the PR.
|
@Saahi30 its been a while since I raised this PR, could you please review it |
Closes #222
📝 Description
added tooltips to navigations icons in dashboard and dashboard/*
This pull request will add hover tooltips to the dashboard navigation icons, improving usability and accessibility.
🔧 Changes Made
Added native browser tooltips to navigation icon buttons by including title={label} on the element.
Ensured the fix preserves all existing functionality, styling, and accessibility (sr-only content still available).
No structural or stylistic changes were introduced — this is a minimal, safe UX improvement.
📷 Screenshot
✅ Checklist
Summary by CodeRabbit
Chores
Style
✏️ Tip: You can customize this high-level summary in your review settings.