Skip to content

Conversation

@JessUWE
Copy link
Contributor

@JessUWE JessUWE commented Jan 20, 2026

Deleted non-functional files from the inst folder: Examples.md, installation.md, supports.md, and welcome.md. Updated the _pkgdown.yml file to reference the new articles located in the Vignettes folder. Created new .Rmd files for installation, supports, welcome, and examples. Revised the Readme.md and Install.md files by removing most of the Python installation configuration code.

Fix formatting and removed the python code

Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Updated installation instructions for acro-r, including prerequisites and step-by-step guidance for setting up Python and R environments.

Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Added a comprehensive installation guide for the acro package, including instructions for CRAN and GitHub installation, prerequisites, initialization, troubleshooting, and verification steps.

Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
This document introduces the ACRO-R package, its features, and usage instructions. It also includes acknowledgements and links to relevant resources.

Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ddb5da0) to head (3028381).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          107       107           
=========================================
  Hits           107       107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JessUWE JessUWE requested a review from rpreen January 20, 2026 12:45
@JessUWE JessUWE changed the title Acro r doc minor glitches changes New-Doc-Minor-glitches-changes Jan 20, 2026
@rpreen rpreen changed the title New-Doc-Minor-glitches-changes docs: reorganise documentation and simplify installation guide Jan 20, 2026
Copy link
Collaborator

@rpreen rpreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me; but it heavily modifies the existing INSTALL.md that @jim-smith wrote, so he should probably confirm this one.

@JessUWE
Copy link
Contributor Author

JessUWE commented Jan 20, 2026

@jim-smith Could you please take a look at the INSTALL.md file to check that it makes sense?

@JessUWE JessUWE merged commit 3173ab8 into main Jan 20, 2026
10 checks passed
@JessUWE JessUWE deleted the Acro-R-doc-minor-glitches-in-new-docs-pages branch January 20, 2026 13:30
@jim-smith
Copy link
Collaborator

@JessUWE you've removed a load of key details from the installation guide

Those may have benefitted from simplifying, but threes ket stuff about changing the value of the environment variable RETICULATE.PYTHON without which it doesn't work- see e.g. what users had to do it the issue about adding conda support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants