Stamp telemetry trash execution #963
Merged
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaliby
requested review from
FIoannides,
SikaGrr,
jamOne- and
stony-tark
as code owners
jamOne-
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change modifies calculation of the
XPK_TESTERflag in telemetry to set it totruewhen theTELEMETRY_TRASH_EXECUTIONenvironment variable is set totrue.I will globally set this flag for all XPK's github action executions on repository level. It will allow us to easily filter out GH automated runs from telemetry data.
Why not rely on
os.getenv("GITHUB_ACTIONS") == "true"?While this will work for our use case, it will also exclude all data, in case XPK is run by a 3rd party within github actions context. Such executions are not trash and should not be treated as a test executions but actual production use cases.
Issue
n/a
Testing
Unit testing