-
Notifications
You must be signed in to change notification settings - Fork 444
Add citation entry for repository #2825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a50a378 to
02e810e
Compare
README.md
Outdated
|
|
||
| To cite the MaxText repository: | ||
| ``` | ||
| @misc{maxtext2023github, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find good alignment on the repo. Shall we use @software instead of @misc. Do you have a source?
I see different examples:
- https://github.com/google-deepmind/dm-haiku - software, same as JAX
- https://github.com/NVIDIA/Megatron-LM?tab=readme-ov-file#citation - article
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@article might not be proper without actual paper. megatron has a arxiv preprint.
@misc can be used for anything, the most generic category.
Yes, we can use @software to be more specific and align with JAX and Haiku.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
| To cite the MaxText repository: | ||
| ``` | ||
| @misc{maxtext2023github, | ||
| author = {{Google Cloud AI Hypercomputer}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss more offline.
README.md
Outdated
| ``` | ||
| @misc{maxtext2023github, | ||
| author = {{Google Cloud AI Hypercomputer}}, | ||
| title = {{M}ax{T}ext: A simple, performant and scalable {JAX} {LLM}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add "training framework" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion! Title updated.
02e810e to
640423a
Compare
640423a to
be93494
Compare
Description
Add repo citation, similar to jax and jiant.
Tests
latex preview: https://screenshot.googleplex.com/5g5WFzTbvRRuEJP
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.