Skip to content

Conversation

@3squared-tommcgurrin
Copy link
Collaborator

  • Assign a value to "first" in table component. This holds the value of the initial row index and allows us manipulte the page index. Doing this allows us to reset the index and therefore the page index back to zero when changing the page size. Without this someone could be on page 2 with a page size of 10, change the page size to 20 and be stuck on a page that has nothing to display.

- Assign a value to "first" in table component. This holds the value of the initial row index and allows us manipulte the page index. Doing this allows us to reset the index and therefore the page index back to zero when changing the page size. Without this someone could be on page 2 with a page size of 10, change the page size to 20 and be stuck on a page that has nothing to display.
@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: 053221b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Change logic so it actually sets page based on current row index/ new page size
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Complexity Health
components 86% 70% 0
components.file-uploader 92% 80% 0
components.file-uploader.components 80% 80% 0
components.table 67% 66% 0
components 86% 70% 0
components.file-uploader 92% 80% 0
components.file-uploader.components 80% 80% 0
components.file-uploader.utilities 68% 62% 0
components.table 67% 67% 0
helpers 44% 21% 0
passthroughs 82% 86% 0
main 20% 100% 0
components 86% 70% 0
components.file-uploader 92% 80% 0
components.file-uploader.components 80% 80% 0
components.table 67% 66% 0
components 86% 70% 0
components.file-uploader 92% 80% 0
components.file-uploader.components 80% 80% 0
components.file-uploader.utilities 68% 62% 0
components.table 67% 67% 0
helpers 44% 21% 0
passthroughs 82% 86% 0
main 20% 100% 0
Summary 60% (1858 / 2382) 82% (1882 / 2580) 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants