Add support for json.Number to dataconv.Marshal
#128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a case to the
dataconv.Marshaltype switch that retains values passed asjson.Numberas their underlying string value.Why
In instances where a user is consuming raw JSON without a predetermined struct for unmarshaling, they often unmarshal into a
map[string]interface{}. When doing this all numbers are converted to floats, even if they have no fractional part. Eg:Therefore a user, in a situation where they are unmarshaling deeply-nested JSON into a
map[string]interface{}and then marshaling usingdataconv.Marshalfor use in Starlark, can expect integers to be misidentified as floats. Checks inside the script will fail to distinguish between integers and floats.To simplify this situation, we ask the Go JSON decoder to use
json.Numbervalues for all numerics.If
dataconv.Marshalconverts the value to a string representation, then we can handle the values differently based onstr.isdigit()andstr.isdecimal()within the script.