Фикс ошибки неизвестного типа значений #561 #562
Conversation
📝 WalkthroughWalkthroughUpdated bsl-common-library dependency from version 0.9.0 to 0.9.1 in the Gradle Kotlin DSL configuration file. This is a patch-level version bump with no other code modifications. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
build.gradle.kts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: build (21, macOS-latest)
- GitHub Check: build (21, windows-latest)
- GitHub Check: QA
- GitHub Check: build (17, windows-latest)
- GitHub Check: build (17, macOS-latest)
- GitHub Check: build (25, macOS-latest)
- GitHub Check: build (21, ubuntu-latest)
- GitHub Check: build (25, windows-latest)
- GitHub Check: build (21, macOS-latest)
- GitHub Check: build (21, windows-latest)
- GitHub Check: build (17, ubuntu-latest)
- GitHub Check: build (25, ubuntu-latest)
| // прочее | ||
| implementation("commons-io", "commons-io", "2.18.0") | ||
| implementation("io.github.1c-syntax", "bsl-common-library", "0.9.0") | ||
| implementation("io.github.1c-syntax", "bsl-common-library", "0.9.1") |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check Maven Central for version 0.9.1 availability
echo "=== Checking Maven Central for bsl-common-library 0.9.1 ==="
curl -s -I "https://repo1.maven.org/maven2/io/github/1c-syntax/bsl-common-library/0.9.1/bsl-common-library-0.9.1.jar" | head -1
# Check available versions
echo -e "\n=== Checking available versions around 0.9.1 ==="
curl -s "https://repo1.maven.org/maven2/io/github/1c-syntax/bsl-common-library/" | grep -o '0\.9\.[0-9]*' | sort -uRepository: 1c-syntax/mdclasses
Length of output: 197
🌐 Web query:
bsl-common-library 0.9.1 release notes 1c-syntax GitHub
💡 Result:
I couldn't find a GitHub release or release notes for bsl-common-library version 0.9.1. The latest published version I can find is 0.9.0 (project homepage and docs show 0.9.0). [1][2][3]
Sources:
- Maven / mvnrepository entry for bsl-common-library (shows 0.9.0). [1]
- 1c-syntax GitHub organization page. [2]
- Javadoc / package page for bsl-common-library (current version 0.9.0). [3]
If you want, I can check the repository's Releases page or tags on GitHub now and report back.
🏁 Script executed:
#!/bin/bash
# Search for references to issue #561 and catalog parsing tests
echo "=== Searching for issue #561 references ==="
rg -i "561|апк.*ферм|cataloglist" --type md --type kt --type java --type gradle
echo -e "\n=== Checking for parsing/catalog related tests ==="
fd -e kt -e java | xargs rg -l "catalog|parse|valueType" -i | head -10Repository: 1c-syntax/mdclasses
Length of output: 878
🏁 Script executed:
#!/bin/bash
# Check GitHub releases for bsl-common-library more directly
echo "=== Checking GitHub API for bsl-common-library releases ==="
curl -s "https://api.github.com/repos/1c-syntax/bsl-common-library/releases" | grep -E '"tag_name"|"name"|"published_at"' | head -20
echo -e "\n=== Checking recent tags ==="
curl -s "https://api.github.com/repos/1c-syntax/bsl-common-library/tags" | grep -E '"name"' | head -10
echo -e "\n=== Checking current mdclasses repository for issue #561 ==="
rg "561" --type md
echo -e "\n=== Looking at CatalogTest for parsing/valueType tests ==="
head -50 src/test/java/com/github/_1c_syntax/bsl/mdo/CatalogTest.javaRepository: 1c-syntax/mdclasses
Length of output: 3071
🌐 Web query:
bsl-common-library GitHub releases 0.9.1
💡 Result:
I couldn't find a GitHub release v0.9.1 for bsl-common-library. The latest published version appears to be 0.9.0 (see Javadoc and Maven listings), and the project repository is 1c-syntax/bsl-common-library on GitHub. [1][2][3]
Sources:
- bsl-common-library Javadoc (current version 0.9.0). [1]
- Maven / mvnrepository listing for bsl-common-library (0.9.0). [2]
- 1c-syntax GitHub organization (repository: bsl-common-library). [3]
🏁 Script executed:
#!/bin/bash
# Get the full release information for v0.9.1
echo "=== Full v0.9.1 release details from bsl-common-library ==="
curl -s "https://api.github.com/repos/1c-syntax/bsl-common-library/releases/tags/v0.9.1" | jq '.body // .name'
echo -e "\n=== Check if issue #561 is in bsl-common-library ==="
curl -s "https://api.github.com/repos/1c-syntax/bsl-common-library/issues/561" | jq '.title, .state, .body' 2>/dev/null | head -20
echo -e "\n=== Check for recent commits in v0.9.1 ==="
curl -s "https://api.github.com/repos/1c-syntax/bsl-common-library/compare/v0.9.0...v0.9.1" | jq '.commits[].message' | head -10Repository: 1c-syntax/mdclasses
Length of output: 549
🏁 Script executed:
#!/bin/bash
# Look for issue reference in build.gradle.kts or git commits
echo "=== Searching for issue references in the PR/commits ==="
rg "561|issue|bug|fix" build.gradle.kts
echo -e "\n=== Check git log for recent commits mentioning the dependency ==="
git log --oneline --all -20 | rg -i "deps|bsl|common|library"
echo -e "\n=== Look at build.gradle.kts context around line 62 ==="
sed -n '55,70p' build.gradle.ktsRepository: 1c-syntax/mdclasses
Length of output: 961
Add regression test and improve commit message.
Version 0.9.1 of bsl-common-library is published and includes the relevant fix: "Added types for Electronic Catalog List and Document List" which addresses the valueType parsing issue. However:
- Add a regression test in this repository to verify that the previously failing case (cfg:CatalogList.АпкФермы with unknown valueType) now parses correctly
- Improve the commit message from "new deps" to something more descriptive like "Bump bsl-common-library to 0.9.1 for catalog valueType parsing fix"
- Complete the PR checklist items (tests and precommit checks)
🤖 Prompt for AI Agents
In build.gradle.kts at line 62, after bumping bsl-common-library to 0.9.1, add a
regression test that loads/parses the previously failing resource
(cfg:CatalogList.АпкФермы) and asserts the valueType is now recognized (or
parsing succeeds without error), update the commit message from "new deps" to
"Bump bsl-common-library to 0.9.1 for catalog valueType parsing fix", and ensure
you complete the PR checklist by adding the new test to the test suite and
re-running precommit checks/CI (fix any lint/test failures) before pushing.
|
Описание
Связанные задачи
Closes #561
Чеклист
Общие
gradlew precommit)Дополнительно
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.