refactor: restructure loadtest into library with mode packages #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move loadtest logic from cmd/loadtest/ to loadtest/ library - Create loadtest/mode/ for shared infrastructure (interface, registry, dependencies, util) - Create loadtest/modes/ for mode implementations - Create loadtest/config/ for configuration types - Refactor UniswapV3Mode to use dependencies directly instead of callback - Fix strings.HasPrefix() argument order in recall.go for ERC20/ERC721 detection - Fix index mismatch in rpc.go using wrong array length after deduplication - Replace println() with fmt.Println() in util.go for proper stdout output - Simplify deduplicate() using maps.Keys and slices.Collect - Rename Initialize to Init in mode interface - Move AccountPoolConfig to loadtest/account.go
minhd-vu
force-pushed
the
minhd-vu/loadtest-subcmds
branch
from
e531c35 to
8a2de58
Compare
Member
|
Looks like it's gonna conflict a lot with this other pending PR: #755 |
leovct
previously approved these changes
Jan 20, 2026
Member
leovct
left a comment
leovct
left a comment
There was a problem hiding this comment.
lgtm, really like the new structure, especially the mode interface!!
leovct
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira / Linear Tickets
Testing