Skip to content

Add safeguards to element cli scripts. #13

@chris-decker-volusion

Description

@chris-decker-volusion
  • I'm submitting...

    • a bug report.
    • a feature request.
    • a support request.
    • a documentation update.
    • something else.
  • What is the current behavior?
    element publish, element release and element rollback all have zero safeguards when running the scripts.

  • What is the expected behavior?

    • element publish (hopefully element stage in the future) should ask if you are making a breaking change when run and add the --new-major flag when true. (What happens if you repeatedly run element publish --new-major before running release? Will it bump the block version by a major version each time or maintain the current major version bump in staging?) This will make it more difficult to accidentally release a breaking change as a minor release.

    • element release should ask you to confirm that you want to push the changes into production. This will make it more difficult to accidentally push unfinished code into production.

    • element rollback should ask you to confirm that you want to rollback to a specific version of the block. It should provide the version number of the current block as well as the version number of the block you're rolling back to. It should also inform you if you are rolling back to a staging or production version.

  • What is the motivation / use case for changing the behavior?
    These safeguards will help prevent accidental production block updates.

  • Please tell us about your environment:

    • Version: 2.0.2
    • OS: All

Metadata

Metadata

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions