fix: TZ prefix should override base date timezone#255
Merged
sylvestre merged 2 commits intouutils:mainfrom Feb 12, 2026
Merged
Conversation
sylvestre
reviewed
Feb 4, 2026
src/items/builder.rs
Outdated
| // while keeping the base's timestamp for relative date calculations. | ||
| let base = match (self.base, &self.timezone) { | ||
| (Some(b), _) => b, | ||
| (Some(b), Some(tz)) => b.timestamp().to_zoned(tz.clone()), |
Contributor
There was a problem hiding this comment.
are you sure the clone are necessary here ?
(if you use self.timezone instead in the match)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the failing date GNU test
cross-TZ-mishandledwhere the TZ environment variable is not being used in when building the Zoned object. The fix is simply to check if the TZ is provided and set the timestamp to_zoned with that timezone.This added no regressions to the main date integ test suite or in the date GNU tests