BridgeJS: Guard FinalizationRegistry deinit callback against Wasm teardown

krodak · krodak · commit 0e6f357181aa · 2026-02-19T11:09:21.000+01:00
diff --git a/Plugins/BridgeJS/Sources/BridgeJSLink/BridgeJSLink.swift b/Plugins/BridgeJS/Sources/BridgeJSLink/BridgeJSLink.swift
@@ -56,7 +56,12 @@ public struct BridgeJSLink {
                 return;
             }
             state.hasReleased = true;
-            state.deinit(state.pointer);
+            try {
+                state.deinit(state.pointer);
+            } catch {
+                // The release call may fail if the Wasm instance has already been torn down
+                // (e.g. during process exit). Nothing we can do at this point.
+            }
         });
 
         /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/ArrayTypes.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/ArrayTypes.js
@@ -340,7 +340,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/DefaultParameters.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/DefaultParameters.js
@@ -277,7 +277,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/DictionaryTypes.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/DictionaryTypes.js
@@ -235,7 +235,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/EnumAssociatedValue.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/EnumAssociatedValue.js
@@ -972,7 +972,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/EnumNamespace.Global.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/EnumNamespace.Global.js
@@ -261,7 +261,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/EnumNamespace.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/EnumNamespace.js
@@ -242,7 +242,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/JSValue.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/JSValue.js
@@ -336,7 +336,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/MixedGlobal.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/MixedGlobal.js
@@ -209,7 +209,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/MixedModules.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/MixedModules.js
@@ -217,7 +217,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/MixedPrivate.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/MixedPrivate.js
@@ -209,7 +209,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Namespaces.Global.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Namespaces.Global.js
@@ -217,7 +217,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Namespaces.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Namespaces.js
@@ -217,7 +217,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Optionals.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Optionals.js
@@ -469,7 +469,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/PropertyTypes.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/PropertyTypes.js
@@ -209,7 +209,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Protocol.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Protocol.js
@@ -568,7 +568,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticFunctions.Global.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticFunctions.Global.js
@@ -255,7 +255,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticFunctions.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticFunctions.js
@@ -255,7 +255,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticProperties.Global.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticProperties.Global.js
@@ -214,7 +214,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticProperties.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticProperties.js
@@ -214,7 +214,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftClass.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftClass.js
@@ -237,7 +237,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftClosure.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftClosure.js
@@ -888,7 +888,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftStruct.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftStruct.js
@@ -483,7 +483,12 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {
+                    // The release call may fail if the Wasm instance has already been torn down
+                    // (e.g. during process exit). Nothing we can do at this point.
+                }
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
