From e54cd506e788bb35a58b1f6089f78e591b0bbaf9 Mon Sep 17 00:00:00 2001 From: Ruben Hoenle Date: Thu, 27 Mar 2025 18:06:49 +0100 Subject: [PATCH 1/3] chore(github): add pull request template relates to STACKITTPR-138 --- .github/pull_request_template.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 000000000..599218b7d --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,15 @@ +## Description + + + +relates to #1234 + +## Checklist + +- [ ] Code format was applied: `make fmt` +- [ ] Docs are up-to-date: `make generate-docs` +- [x] No linter issues: `make lint` (will be checked by CI) +- [x] Unit tests are passing: `make test` (will be checked by CI) From 902cfe8c30fe061e9927eab5fe90774cdafb3a1a Mon Sep 17 00:00:00 2001 From: Ruben Hoenle Date: Fri, 28 Mar 2025 10:30:35 +0100 Subject: [PATCH 2/3] add unit test implementation to checklist --- .github/pull_request_template.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 599218b7d..36782f0b1 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -9,7 +9,9 @@ relates to #1234 ## Checklist +- [ ] Issue was linked above - [ ] Code format was applied: `make fmt` - [ ] Docs are up-to-date: `make generate-docs` -- [x] No linter issues: `make lint` (will be checked by CI) +- [ ] Unit tests got implemented or updated - [x] Unit tests are passing: `make test` (will be checked by CI) +- [x] No linter issues: `make lint` (will be checked by CI) From 1a5aea4243613fb8e90386a69fbe393da60d3ffe Mon Sep 17 00:00:00 2001 From: Ruben Hoenle Date: Fri, 28 Mar 2025 10:44:07 +0100 Subject: [PATCH 3/3] add example updates to checklist --- .github/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 36782f0b1..088dfb4c4 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -11,6 +11,7 @@ relates to #1234 - [ ] Issue was linked above - [ ] Code format was applied: `make fmt` +- [ ] Examples were added / adjusted (see e.g. [here](https://github.com/stackitcloud/stackit-cli/blob/ef291d1683ca5b0d719ec0a26ecb999a32685117/internal/cmd/ske/cluster/create/create.go#L49-L63)) - [ ] Docs are up-to-date: `make generate-docs` - [ ] Unit tests got implemented or updated - [x] Unit tests are passing: `make test` (will be checked by CI)