add support for updating DNS TXT records with values > 255 characters

Author: marceljk

internal/cmd/dns/record-set/update/update.go

@@ -3,6 +3,7 @@ package update
 import (
 	"context"
 	"fmt"
+	"math"
 
 	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/errors"
@@ -28,6 +29,7 @@ const (
 	nameFlag    = "name"
 	recordFlag  = "record"
 	ttlFlag     = "ttl"
+	txtType     = "TXT"
 )
 
 type inputModel struct {
@@ -38,6 +40,7 @@ type inputModel struct {
 	Name        *string
 	Records     *[]string
 	TTL         *int64
+	Type        *string
 }
 
 func NewCmd(p *print.Printer) *cobra.Command {
@@ -76,6 +79,12 @@ func NewCmd(p *print.Printer) *cobra.Command {
 				recordSetLabel = model.RecordSetId
 			}
 
+			typeLabel, err := dnsUtils.GetRecordSetType(ctx, apiClient, model.ProjectId, model.ZoneId, model.RecordSetId)
+			if err != nil {
+				p.Debug(print.ErrorLevel, "get record set type: %v", err)
+			}
+			model.Type = typeLabel
+
 			if !model.AssumeYes {
 				prompt := fmt.Sprintf("Are you sure you want to update record set %s of zone %s?", recordSetLabel, zoneLabel)
 				err = p.PromptForConfirmation(prompt)
@@ -170,7 +179,23 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *dns.APIClie
 	if model.Records != nil {
 		records = utils.Ptr(make([]dns.RecordPayload, 0))
 		for _, r := range *model.Records {
-			records = utils.Ptr(append(*records, dns.RecordPayload{Content: utils.Ptr(r)}))
+			result := r
+			if len(r) > 255 && utils.PtrString(model.Type) == txtType {
+				result = ""
+				length := float64(len(r))
+				chunks := int(math.Ceil(length / 255))
+				for i := range chunks {
+					skip := 255 * i
+					if i == chunks-1 {
+						// Append the left record content
+						result += fmt.Sprintf("%q", r[0+skip:])
+					} else {
+						// Add 255 characters of the record data quoted to the result
+						result += fmt.Sprintf("%q ", r[0+skip:255+skip])
+					}
+				}
+			}
+			records = utils.Ptr(append(*records, dns.RecordPayload{Content: utils.Ptr(result)}))
 		}
 	}
 

internal/cmd/dns/record-set/update/update_test.go

@@ -2,6 +2,8 @@ package update
 
 import (
 	"context"
+	"fmt"
+	"strings"
 	"testing"
 
 	"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
@@ -24,6 +26,12 @@ var testProjectId = uuid.NewString()
 var testZoneId = uuid.NewString()
 var testRecordSetId = uuid.NewString()
 
+var recordTxtOver255Char = []string{
+	"foobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoo",
+	"foobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoo",
+	"foobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobar",
+}
+
 func fixtureArgValues(mods ...func(argValues []string)) []string {
 	argValues := []string{
 		testRecordSetId,
@@ -330,6 +338,26 @@ func TestBuildRequest(t *testing.T) {
 			expectedRequest: testClient.PartialUpdateRecordSet(testCtx, testProjectId, testZoneId, testRecordSetId).
 				PartialUpdateRecordSetPayload(dns.PartialUpdateRecordSetPayload{}),
 		},
+		{
+			description: "update TXT record with > 255 characters",
+			model: fixtureInputModel(func(model *inputModel) {
+				model.Type = utils.Ptr(txtType)
+				model.Records = utils.Ptr([]string{strings.Join(recordTxtOver255Char, "")})
+			}),
+			expectedRequest: testClient.PartialUpdateRecordSet(testCtx, testProjectId, testZoneId, testRecordSetId).
+				PartialUpdateRecordSetPayload(dns.PartialUpdateRecordSetPayload{
+					Name: utils.Ptr("example.com"),
+					Records: &[]dns.RecordPayload{
+						{
+							Content: utils.Ptr(
+								fmt.Sprintf("\"%s\"", strings.Join(recordTxtOver255Char, "\" \"")),
+							),
+						},
+					},
+					Comment: utils.Ptr("comment"),
+					Ttl:     utils.Ptr(int64(3600)),
+				}),
+		},
 	}
 
 	for _, tt := range tests {

internal/pkg/services/dns/utils/utils.go

@@ -3,6 +3,7 @@ package utils
 import (
 	"context"
 	"fmt"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 
 	"github.com/stackitcloud/stackit-sdk-go/services/dns"
 )
@@ -27,3 +28,11 @@ func GetRecordSetName(ctx context.Context, apiClient DNSClient, projectId, zoneI
 	}
 	return *resp.Rrset.Name, nil
 }
+
+func GetRecordSetType(ctx context.Context, apiClient DNSClient, projectId, zoneId, recordSetId string) (*string, error) {
+	resp, err := apiClient.GetRecordSetExecute(ctx, projectId, zoneId, recordSetId)
+	if err != nil {
+		return utils.Ptr(""), fmt.Errorf("get DNS recordset: %w", err)
+	}
+	return resp.Rrset.Type, nil
+}