fix utils tests

Author: Benjosh95

internal/pkg/utils/utils_test.go

@@ -546,53 +546,45 @@ func TestBase64Bytes_MarshalYAML(t *testing.T) {
 }
 func TestGetSliceFromPointer(t *testing.T) {
 	tests := []struct {
-		name      string
-		input     *[]string
-		expected  []string
-		expectNil bool
+		name     string
+		input    *[]string
+		expected []string
 	}{
 		{
-			name:      "nil pointer",
-			input:     nil,
-			expected:  []string{},
-			expectNil: false,
+			name:     "nil pointer",
+			input:    nil,
+			expected: []string{},
 		},
 		{
 			name: "pointer to nil slice",
 			input: func() *[]string {
 				var s []string
 				return &s
 			}(),
-			expected:  nil,
-			expectNil: true,
+			expected: []string{},
 		},
 		{
-			name:      "empty slice",
-			input:     &[]string{},
-			expected:  []string{},
-			expectNil: false,
+			name:     "empty slice",
+			input:    &[]string{},
+			expected: []string{},
 		},
 		{
-			name:      "populated slice",
-			input:     &[]string{"item1", "item2"},
-			expected:  []string{"item1", "item2"},
-			expectNil: false,
+			name:     "populated slice",
+			input:    &[]string{"item1", "item2"},
+			expected: []string{"item1", "item2"},
 		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			result := GetSliceFromPointer(tt.input)
 
-			if tt.expectNil {
-				if result != nil {
-					t.Errorf("GetSliceFromPointer() = %v, want nil", result)
-				}
+			if result == nil && tt.expected == nil {
 				return
 			}
 
-			if result == nil {
-				t.Errorf("GetSliceFromPointer() = nil, want %v", tt.expected)
+			if (result == nil && tt.expected != nil) || (result != nil && tt.expected == nil) {
+				t.Errorf("GetSliceFromPointer() = %v, want %v", result, tt.expected)
 				return
 			}