review changes 3

Author: h3adex

docs/stackit_routing-table_create.md

@@ -19,10 +19,10 @@ stackit routing-table create [flags]
   Create a routing-table with name `rt` and description `some description`
   stackit routing-table create --organization-id xxx --network-area-id yyy --name "rt" --description "some description"
 
-  Create a routing-table with name `rt` with system_routes disabled
+  Create a routing-table with name `rt` with system routes disabled
   stackit routing-table create --organization-id xxx --network-area-id yyy --name "rt" --non-system-routes
 
-  Create a routing-table with name `rt` with dynamic_routes disabled
+  Create a routing-table with name `rt` with dynamic routes disabled
   stackit routing-table create --organization-id xxx --network-area-id yyy --name "rt" --non-dynamic-routes
 ```
 

docs/stackit_routing-table_delete.md

@@ -7,7 +7,7 @@ Deletes a routing-table
 Deletes a routing-table
 
 ```
-stackit routing-table delete ROUTING_TABLE_ARG [flags]
+stackit routing-table delete ROUTING_TABLE [flags]
 ```
 
 ### Examples

docs/stackit_routing-table_describe.md

@@ -7,7 +7,7 @@ Describes a routing-table
 Describes a routing-table
 
 ```
-stackit routing-table describe ROUTING_TABLE_ID_ARG [flags]
+stackit routing-table describe ROUTING_TABLE_ID [flags]
 ```
 
 ### Examples

docs/stackit_routing-table_route_describe.md

@@ -7,7 +7,7 @@ Describes a route within a routing-table
 Describes a route within a routing-table
 
 ```
-stackit routing-table route describe ROUTE_ID_ARG [flags]
+stackit routing-table route describe ROUTE_ID [flags]
 ```
 
 ### Examples

docs/stackit_routing-table_route_update.md

@@ -7,7 +7,7 @@ Updates a route in a routing-table
 Updates a route in a routing-table.
 
 ```
-stackit routing-table route update ROUTE_ID_ARG [flags]
+stackit routing-table route update ROUTE_ID [flags]
 ```
 
 ### Examples

docs/stackit_routing-table_update.md

@@ -7,7 +7,7 @@ Updates a routing-table
 Updates a routing-table.
 
 ```
-stackit routing-table update ROUTE_TABLE_ID_ARG [flags]
+stackit routing-table update ROUTE_TABLE_ID [flags]
 ```
 
 ### Examples
@@ -22,7 +22,7 @@ stackit routing-table update ROUTE_TABLE_ID_ARG [flags]
   Updates the description of a routing-table with ID "xxx" in organization with ID "yyy" and network-area with ID "zzz"
   $ stackit routing-table update xxx --description foo --organization-id yyy --network-area-id zzz
 
-  Disables the dynamic_routes of a routing-table with ID "xxx" in organization with ID "yyy" and network-area with ID "zzz"
+  Disables the dynamic routes of a routing-table with ID "xxx" in organization with ID "yyy" and network-area with ID "zzz"
   $ stackit routing-table update xxx --organization-id yyy --network-area-id zzz --non-dynamic-routes
 ```
 

internal/cmd/network/describe/describe.go

@@ -152,7 +152,7 @@ func outputResult(p *print.Printer, outputFormat string, network *iaas.Network)
 		table.AddSeparator()
 
 		if network.RoutingTableId != nil {
-			table.AddRow("ROUTING-TABLE ID", utils.PtrString(network.RoutingTableId))
+			table.AddRow("ROUTING TABLE ID", utils.PtrString(network.RoutingTableId))
 			table.AddSeparator()
 		}
 

internal/cmd/routingtable/create/create.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"fmt"
 	"strings"
-	"time"
 
 	"github.com/spf13/cobra"
 	"github.com/stackitcloud/stackit-cli/internal/cmd/params"
@@ -56,11 +55,11 @@ func NewCmd(params *params.CmdParams) *cobra.Command {
 				`stackit routing-table create --organization-id xxx --network-area-id yyy --name "rt" --description "some description"`,
 			),
 			examples.NewExample(
-				"Create a routing-table with name `rt` with system_routes disabled",
+				"Create a routing-table with name `rt` with system routes disabled",
 				`stackit routing-table create --organization-id xxx --network-area-id yyy --name "rt" --non-system-routes`,
 			),
 			examples.NewExample(
-				"Create a routing-table with name `rt` with dynamic_routes disabled",
+				"Create a routing-table with name `rt` with dynamic routes disabled",
 				`stackit routing-table create --organization-id xxx --network-area-id yyy --name "rt" --non-dynamic-routes`,
 			),
 		),
@@ -175,28 +174,18 @@ func outputResult(p *print.Printer, outputFormat string, routingTable *iaas.Rout
 			}
 		}
 
-		createdAt := ""
-		if routingTable.CreatedAt != nil {
-			createdAt = routingTable.CreatedAt.Format(time.RFC3339)
-		}
-
-		updatedAt := ""
-		if routingTable.UpdatedAt != nil {
-			updatedAt = routingTable.UpdatedAt.Format(time.RFC3339)
-		}
-
 		table := tables.NewTable()
-		table.SetHeader("ID", "NAME", "DESCRIPTION", "CREATED_AT", "UPDATED_AT", "DEFAULT", "LABELS", "SYSTEM_ROUTES", "DYNAMIC_ROUTES")
+		table.SetHeader("ID", "NAME", "DESCRIPTION", "DEFAULT", "LABELS", "SYSTEM ROUTES", "DYNAMIC ROUTES", "CREATED AT", "UPDATED AT")
 		table.AddRow(
 			utils.PtrString(routingTable.Id),
 			utils.PtrString(routingTable.Name),
 			utils.PtrString(routingTable.Description),
-			createdAt,
-			updatedAt,
 			utils.PtrString(routingTable.Default),
 			strings.Join(labels, "\n"),
 			utils.PtrString(routingTable.SystemRoutes),
 			utils.PtrString(routingTable.DynamicRoutes),
+			utils.ConvertTimePToDateTimeString(routingTable.CreatedAt),
+			utils.ConvertTimePToDateTimeString(routingTable.UpdatedAt),
 		)
 
 		err := table.Display(p)

internal/cmd/routingtable/create/create_test.go

@@ -11,7 +11,7 @@ import (
 	"github.com/google/uuid"
 	"github.com/stackitcloud/stackit-cli/internal/cmd/params"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
-	pprint "github.com/stackitcloud/stackit-cli/internal/pkg/print"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/testutils"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 	"github.com/stackitcloud/stackit-sdk-go/services/iaas"
@@ -134,7 +134,7 @@ func TestParseInput(t *testing.T) {
 			}),
 		},
 		{
-			description: "system_routes disabled",
+			description: "system routes disabled",
 			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
 				flagValues[nonSystemRoutesFlag] = "true"
 			}),
@@ -319,26 +319,32 @@ func TestOutputResult(t *testing.T) {
 			wantErr:      true,
 		},
 		{
-			name:         "table output routing-table",
+			name:         "default output routing-table",
 			outputFormat: "",
 			routingTable: &dummyRoutingTable,
 			wantErr:      false,
 		},
+		{
+			name:         "table output routing-table",
+			outputFormat: print.PrettyOutputFormat,
+			routingTable: &dummyRoutingTable,
+			wantErr:      false,
+		},
 		{
 			name:         "json output routing-table",
-			outputFormat: pprint.JSONOutputFormat,
+			outputFormat: print.JSONOutputFormat,
 			routingTable: &dummyRoutingTable,
 			wantErr:      false,
 		},
 		{
 			name:         "yaml output routing-table",
-			outputFormat: pprint.YAMLOutputFormat,
+			outputFormat: print.YAMLOutputFormat,
 			routingTable: &dummyRoutingTable,
 			wantErr:      false,
 		},
 	}
 
-	p := pprint.NewPrinter()
+	p := print.NewPrinter()
 	p.Cmd = NewCmd(&params.CmdParams{Printer: p})
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

internal/cmd/routingtable/delete/delete.go

@@ -18,7 +18,7 @@ import (
 const (
 	networkAreaIdFlag  = "network-area-id"
 	organizationIdFlag = "organization-id"
-	routingTableIdArg  = "ROUTING_TABLE_ARG"
+	routingTableIdArg  = "ROUTING_TABLE"
 )
 
 type inputModel struct {
@@ -94,9 +94,6 @@ func configureFlags(cmd *cobra.Command) {
 func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inputModel, error) {
 	globalFlags := globalflags.Parse(p, cmd)
 
-	if len(inputArgs) == 0 {
-		return nil, fmt.Errorf("at least one argument is required")
-	}
 	routingTableId := inputArgs[0]
 
 	model := inputModel{