feature: fix regressions

Author: bahkauv70

internal/cmd/beta/security-group/delete/delete.go

@@ -10,14 +10,15 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/examples"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/projectname"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/iaas/client"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 	"github.com/stackitcloud/stackit-sdk-go/services/iaas"
 )
 
 type inputModel struct {
 	*globalflags.GlobalFlagModel
-	Id string
+	SecurityGroupId string
 }
 
 const groupIdArg = "GROUP_ID"
@@ -44,8 +45,18 @@ func NewCmd(p *print.Printer) *cobra.Command {
 				return err
 			}
 
+			projectLabel, err := projectname.GetProjectName(ctx, p, cmd)
+			if err != nil {
+				return fmt.Errorf("get project name: %w", err)
+			}
+
+			securityGroupResp, err := apiClient.GetSecurityGroup(ctx, model.ProjectId, model.SecurityGroupId).Execute()
+			if err != nil {
+				return fmt.Errorf("get security group %q: %w", model.SecurityGroupId, err)
+			}
+
 			if !model.AssumeYes {
-				prompt := fmt.Sprintf("Are you sure you want to delete the security group %q?", model.Id)
+				prompt := fmt.Sprintf("Are you sure you want to delete the security group %q for %q?", *securityGroupResp.Name, projectLabel)
 				err = p.PromptForConfirmation(prompt)
 				if err != nil {
 					return err
@@ -58,7 +69,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			if err := request.Execute(); err != nil {
 				return fmt.Errorf("delete security group: %w", err)
 			}
-			p.Info("Deleted security group %q for %q\n", model.Id, model.ProjectId)
+			p.Info("Deleted security group %q for %q\n", *securityGroupResp.Name, projectLabel)
 
 			return nil
 		},
@@ -75,7 +86,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, cliArgs []string) (*inputM
 
 	model := inputModel{
 		GlobalFlagModel: globalFlags,
-		Id:              cliArgs[0],
+		SecurityGroupId: cliArgs[0],
 	}
 
 	if p.IsVerbosityDebug() {
@@ -91,6 +102,6 @@ func parseInput(p *print.Printer, cmd *cobra.Command, cliArgs []string) (*inputM
 }
 
 func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APIClient) iaas.ApiDeleteSecurityGroupRequest {
-	request := apiClient.DeleteSecurityGroup(ctx, model.ProjectId, model.Id)
+	request := apiClient.DeleteSecurityGroup(ctx, model.ProjectId, model.SecurityGroupId)
 	return request
 }

internal/cmd/beta/security-group/delete/delete_test.go

@@ -37,7 +37,7 @@ func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]st
 func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
 	model := &inputModel{
 		GlobalFlagModel: &globalflags.GlobalFlagModel{ProjectId: testProjectId, Verbosity: globalflags.VerbosityDefault},
-		Id:              testGroupId,
+		SecurityGroupId: testGroupId,
 	}
 	for _, mod := range mods {
 		mod(model)

internal/cmd/beta/security-group/list/list.go

@@ -37,7 +37,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 		Args:  args.NoArgs,
 		Example: examples.Build(
 			examples.NewExample(`List all groups`, `$ stackit beta security-group list`),
-			examples.NewExample(`List groups with labels`, `$ stackit beta security-group list --labels label1=value1,label2=value2`),
+			examples.NewExample(`List groups with labels`, `$ stackit beta security-group list --label-selector label1=value1,label2=value2`),
 		),
 		RunE: func(cmd *cobra.Command, _ []string) error {
 			ctx := context.Background()

internal/cmd/beta/security-group/update/update.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 
 	"github.com/spf13/cobra"
+	cmd_utils "github.com/stackitcloud/stackit-cli/internal/cmd/beta/security-group/utils"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/errors"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/examples"
@@ -62,14 +63,22 @@ func NewCmd(p *print.Printer) *cobra.Command {
 				projectLabel = model.ProjectId
 			}
 
+			if !model.AssumeYes {
+				prompt := fmt.Sprintf("Are you sure you want to update the security group %q?", model.SecurityGroupId)
+				err = p.PromptForConfirmation(prompt)
+				if err != nil {
+					return err
+				}
+			}
+
 			// Call API
 			req := buildRequest(ctx, model, apiClient)
 
-			_, err = req.Execute()
+			resp, err := req.Execute()
 			if err != nil {
 				return fmt.Errorf("update security group: %w", err)
 			}
-			p.Info("Updated security group \"%v\" for %q\n", model.Name, projectLabel)
+			p.Info("Updated security group \"%v\" for %q\n", cmd_utils.PtrString(resp.Name), projectLabel)
 
 			return nil
 		},
@@ -99,6 +108,10 @@ func parseInput(p *print.Printer, cmd *cobra.Command, cliArgs []string) (*inputM
 		SecurityGroupId: cliArgs[0],
 	}
 
+	if model.Labels==nil && model.Description==nil && model.Name==nil {
+		return nil,fmt.Errorf("no flags have been passed")
+	}
+
 	if p.IsVerbosityDebug() {
 		modelStr, err := print.BuildDebugStrFromInputModel(model)
 		if err != nil {

internal/cmd/beta/security-group/update/update_test.go

@@ -104,7 +104,7 @@ func TestParseInput(t *testing.T) {
 				projectIdFlag: testProjectId,
 			},
 			args:    testGroupId,
-			isValid: true,
+			isValid: false,
 			expectedModel: fixtureInputModel(func(model *inputModel) {
 				model.Labels = nil
 				model.Name = nil