fix: integrate review findings

Author: bahkauv70

internal/cmd/rabbitmq/credentials/create/create_test.go

@@ -222,6 +222,16 @@ func Test_outputResult(t *testing.T) {
 			},
 			wantErr: false,
 		},
+		{
+			name: "nil response",
+			args: args{
+				model: inputModel{
+					GlobalFlagModel: &globalflags.GlobalFlagModel{},
+				},
+				instanceLabel: "",
+			},
+			wantErr: true,
+		},
 		{
 			name: "no flags",
 			args: args{

internal/cmd/rabbitmq/credentials/describe/describe_test.go

@@ -261,6 +261,13 @@ func Test_outputResult(t *testing.T) {
 			},
 			wantErr: false,
 		},
+		{
+			name: "empty",
+			args: args{
+				outputFormat: "",
+			},
+			wantErr: true,
+		},
 	}
 	p := print.NewPrinter()
 	p.Cmd = NewCmd(p)

internal/cmd/rabbitmq/instance/create/create.go

@@ -263,6 +263,10 @@ func outputResult(p *print.Printer, model *inputModel, projectLabel, instanceId
 	if model.GlobalFlagModel == nil {
 		return fmt.Errorf("no globalflags passed")
 	}
+	if resp == nil {
+		return fmt.Errorf("no response passed")
+	}
+
 	switch model.OutputFormat {
 	case print.JSONOutputFormat:
 		details, err := json.MarshalIndent(resp, "", "  ")

internal/cmd/rabbitmq/instance/create/create_test.go

@@ -501,10 +501,24 @@ func Test_outputResult(t *testing.T) {
 		wantErr bool
 	}{
 		{
-			name:    "empty",
-			args:    args{model: inputModel{GlobalFlagModel: &globalflags.GlobalFlagModel{}}},
+			name: "empty",
+			args: args{
+				model: inputModel{
+					GlobalFlagModel: &globalflags.GlobalFlagModel{},
+				},
+				resp: &rabbitmq.CreateInstanceResponse{},
+			},
 			wantErr: false,
 		},
+		{
+			name: "empty",
+			args: args{
+				model: inputModel{
+					GlobalFlagModel: &globalflags.GlobalFlagModel{},
+				},
+			},
+			wantErr: true,
+		},
 	}
 	p := print.NewPrinter()
 	p.Cmd = NewCmd(p)

internal/cmd/rabbitmq/instance/describe/describe_test.go

@@ -231,6 +231,11 @@ func Test_outputResult(t *testing.T) {
 			args:    args{instance: &rabbitmq.Instance{}},
 			wantErr: false,
 		},
+		{
+			name:    "nil instance",
+			args:    args{},
+			wantErr: true,
+		},
 		{
 			name: "empty parameters",
 			args: args{

internal/cmd/rabbitmq/plans/plans.go

@@ -164,8 +164,8 @@ func outputResult(p *print.Printer, outputFormat string, plans []rabbitmq.Offeri
 						utils.PtrString(plan.Description),
 					)
 				}
+				table.AddSeparator()
 			}
-			table.AddSeparator()
 		}
 		table.EnableAutoMergeOnColumns(1, 2)
 		err := table.Display(p)