feature: implemented review suggestions

Author: bahkauv70

internal/cmd/beta/security-group/delete/delete.go

@@ -12,6 +12,7 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/projectname"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/iaas/client"
+	iaasUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/iaas/utils"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 	"github.com/stackitcloud/stackit-sdk-go/services/iaas"
 )
@@ -47,16 +48,18 @@ func NewCmd(p *print.Printer) *cobra.Command {
 
 			projectLabel, err := projectname.GetProjectName(ctx, p, cmd)
 			if err != nil {
-				return fmt.Errorf("get project name: %w", err)
+				p.Debug(print.ErrorLevel, "get project name: %v", err)
+				projectLabel = model.ProjectId
 			}
 
-			securityGroupResp, err := apiClient.GetSecurityGroup(ctx, model.ProjectId, model.SecurityGroupId).Execute()
+			groupLabel, err := iaasUtils.GetSecurityGroupName(ctx, apiClient, model.ProjectId, model.SecurityGroupId)
 			if err != nil {
-				return fmt.Errorf("get security group %q: %w", model.SecurityGroupId, err)
+				p.Warn("get security group name: %v", err)
+				groupLabel = model.SecurityGroupId
 			}
 
 			if !model.AssumeYes {
-				prompt := fmt.Sprintf("Are you sure you want to delete the security group %q for %q?", *securityGroupResp.Name, projectLabel)
+				prompt := fmt.Sprintf("Are you sure you want to delete the security group %q for %q?", groupLabel, projectLabel)
 				err = p.PromptForConfirmation(prompt)
 				if err != nil {
 					return err
@@ -69,7 +72,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			if err := request.Execute(); err != nil {
 				return fmt.Errorf("delete security group: %w", err)
 			}
-			p.Info("Deleted security group %q for %q\n", *securityGroupResp.Name, projectLabel)
+			p.Info("Deleted security group %q for %q\n", groupLabel, projectLabel)
 
 			return nil
 		},

internal/cmd/beta/security-group/list/list.go

@@ -7,7 +7,6 @@ import (
 
 	"github.com/goccy/go-yaml"
 	"github.com/spf13/cobra"
-	"github.com/stackitcloud/stackit-cli/internal/cmd/beta/security-group/utils"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/errors"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/examples"
@@ -17,6 +16,7 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/projectname"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/iaas/client"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/tables"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 	"github.com/stackitcloud/stackit-sdk-go/services/iaas"
 )
 

internal/cmd/beta/security-group/update/update.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 
 	"github.com/spf13/cobra"
-	cmd_utils "github.com/stackitcloud/stackit-cli/internal/cmd/beta/security-group/utils"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/errors"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/examples"
@@ -14,6 +13,7 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/projectname"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/iaas/client"
+	iaasUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/iaas/utils"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 	"github.com/stackitcloud/stackit-sdk-go/services/iaas"
 )
@@ -63,8 +63,14 @@ func NewCmd(p *print.Printer) *cobra.Command {
 				projectLabel = model.ProjectId
 			}
 
+			groupLabel, err := iaasUtils.GetSecurityGroupName(ctx, apiClient, model.ProjectId, model.SecurityGroupId)
+			if err != nil {
+				p.Warn("cannot retrieve groupname: %v", err)
+				groupLabel = model.SecurityGroupId
+			}
+
 			if !model.AssumeYes {
-				prompt := fmt.Sprintf("Are you sure you want to update the security group %q?", model.SecurityGroupId)
+				prompt := fmt.Sprintf("Are you sure you want to update the security group %q?", groupLabel)
 				err = p.PromptForConfirmation(prompt)
 				if err != nil {
 					return err
@@ -78,7 +84,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			if err != nil {
 				return fmt.Errorf("update security group: %w", err)
 			}
-			p.Info("Updated security group \"%v\" for %q\n", cmd_utils.PtrString(resp.Name), projectLabel)
+			p.Info("Updated security group \"%v\" for %q\n", utils.PtrString(resp.Name), projectLabel)
 
 			return nil
 		},

internal/cmd/beta/security-group/utils/utils.go

@@ -662,3 +662,5 @@ func TestGetNetworkRangeFromAPIResponse(t *testing.T) {
 		})
 	}
 }
+
+

internal/pkg/services/iaas/utils/utils_test.go

@@ -16,6 +16,15 @@ func Ptr[T any](v T) *T {
 	return &v
 }
 
+// PtrString creates a string representation of a passed object pointer or returns
+// an empty string, if the passed object is _nil_.
+func PtrString[T any](t *T) string {
+	if t != nil {
+		return fmt.Sprintf("%v", *t)
+	}
+	return ""
+}
+
 // Int64Ptr returns a pointer to an int64
 // Needed because the Ptr function only returns pointer to int
 func Int64Ptr(i int64) *int64 {