libANGLE does not build on GCC 11

[angelsl]

There is a missing

#include <limits>

in libANGLE's src/libANGLE/HandleAllocator.cpp.

Note that the upstream libANGLE does not have this issue because of #include <mutex> in src/common/debug.h, which indirectly includes limits. The (rather old) version of libANGLE used in this package does not have that.

Not including limits directly is bad practice by upstream, but in any case, this package is broken.

[dhritzkiv]

Thanks for the details!

A while back (late 2017), I took a stab at updating headless-gl's referenced version of libANGLE, but I didn't get very far as I had build tool problems as well as problems in passing the test suite. I'd love to try again, with a more recent patch of ANGLE, but I unfortunately don't have the time (or skill) to effectively tackle the problem myself.

If you're willing, you can submit a patch, even if it's just to add the missing limits to HandleAllocator.cpp. Note that the currently referenced version of ANGLE is in this forked repo, so you'd have to fork that.

[Rush]

I upgraded dependencies on openSUSE Tumbleweed and also started getting build errors:

npm ERR! In file included from ../angle/src/compiler/preprocessor/DirectiveParser.cpp:17:
npm ERR! ../angle/src/compiler/preprocessor/MacroExpander.h:86:10: warning: ‘template<class> class std::auto_ptr’ is deprecated: use 'std::unique_ptr' instead [-Wdeprecated-declarations]
npm ERR!    86 |     std::auto_ptr<Token> mReserveToken;
npm ERR!       |          ^~~~~~~~
npm ERR! In file included from /usr/include/c++/11/memory:76,
npm ERR!                  from ../angle/src/compiler/preprocessor/MacroExpander.h:11,
npm ERR!                  from ../angle/src/compiler/preprocessor/DirectiveParser.cpp:17:
npm ERR! /usr/include/c++/11/bits/unique_ptr.h:57:28: note: declared here
npm ERR!    57 |   template<typename> class auto_ptr;
npm ERR!       |                            ^~~~~~~~
npm ERR! In file included from ../angle/src/compiler/preprocessor/MacroExpander.cpp:7:
npm ERR! ../angle/src/compiler/preprocessor/MacroExpander.h:86:10: warning: ‘template<class> class std::auto_ptr’ is deprecated: use 'std::unique_ptr' instead [-Wdeprecated-declarations]
npm ERR!    86 |     std::auto_ptr<Token> mReserveToken;
npm ERR!       |          ^~~~~~~~
npm ERR! In file included from /usr/include/c++/11/memory:76,
npm ERR!                  from ../angle/src/compiler/preprocessor/MacroExpander.h:11,
npm ERR!                  from ../angle/src/compiler/preprocessor/MacroExpander.cpp:7:
npm ERR! /usr/include/c++/11/bits/unique_ptr.h:57:28: note: declared here
npm ERR!    57 |   template<typename> class auto_ptr;
npm ERR!       |                            ^~~~~~~~
npm ERR! In file included from ../angle/src/compiler/preprocessor/Preprocessor.cpp:14:
npm ERR! ../angle/src/compiler/preprocessor/MacroExpander.h:86:10: warning: ‘template<class> class std::auto_ptr’ is deprecated: use 'std::unique_ptr' instead [-Wdeprecated-declarations]
npm ERR!    86 |     std::auto_ptr<Token> mReserveToken;
npm ERR!       |          ^~~~~~~~
npm ERR! In file included from /usr/include/c++/11/memory:76,
npm ERR!                  from ../angle/src/compiler/preprocessor/MacroExpander.h:11,
npm ERR!                  from ../angle/src/compiler/preprocessor/Preprocessor.cpp:14:
npm ERR! /usr/include/c++/11/bits/unique_ptr.h:57:28: note: declared here
npm ERR!    57 |   template<typename> class auto_ptr;
npm ERR!       |                            ^~~~~~~~
npm ERR! ../angle/src/compiler/translator/ParseContext.cpp: In member function ‘bool TParseContext::binaryOpCommonCheck(TOperator, TIntermTyped*, TIntermTyped*, const TSourceLoc&)’:
npm ERR! ../angle/src/compiler/translator/ParseContext.cpp:3655:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
npm ERR!  3655 |             if ((mShaderVersion < 300 || op == EOpAssign || op == EOpInitialize) &&
npm ERR!       |             ^~
npm ERR! ../angle/src/compiler/translator/ParseContext.cpp:3662:9: note: here
npm ERR!  3662 |         case EOpLessThan:
npm ERR!       |         ^~~~
npm ERR! ../angle/src/libANGLE/HandleAllocator.cpp: In constructor ‘gl::HandleAllocator::HandleAllocator()’:
npm ERR! ../angle/src/libANGLE/HandleAllocator.cpp:29:52: error: ‘numeric_limits’ is not a member of ‘std’
npm ERR!    29 |     mUnallocatedList.push_back(HandleRange(1, std::numeric_limits<GLuint>::max()));
npm ERR!       |                                                    ^~~~~~~~~~~~~~
npm ERR! ../angle/src/libANGLE/HandleAllocator.cpp:29:76: error: ‘::max’ has not been declared; did you mean ‘std::max’?
npm ERR!    29 |     mUnallocatedList.push_back(HandleRange(1, std::numeric_limits<GLuint>::max()));
npm ERR!       |                                                                            ^~~
npm ERR!       |                                                                            std::max
npm ERR! In file included from /usr/include/c++/11/algorithm:62,
npm ERR!                  from ../angle/src/libANGLE/HandleAllocator.cpp:12:
npm ERR! /usr/include/c++/11/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
npm ERR!  3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
npm ERR!       |     ^~~
npm ERR! ../angle/src/libANGLE/HandleAllocator.cpp:29:43: error: expected primary-expression before ‘(’ token
npm ERR!    29 |     mUnallocatedList.push_back(HandleRange(1, std::numeric_limits<GLuint>::max()));
npm ERR!       |                                           ^
npm ERR! ../angle/src/libANGLE/HandleAllocator.cpp:29:52: error: ‘numeric_limits’ is not a member of ‘std’
npm ERR!    29 |     mUnallocatedList.push_back(HandleRange(1, std::numeric_limits<GLuint>::max()));
npm ERR!       |                                                    ^~~~~~~~~~~~~~
npm ERR! ../angle/src/libANGLE/HandleAllocator.cpp:29:73: error: expected primary-expression before ‘>’ token
npm ERR!    29 |     mUnallocatedList.push_back(HandleRange(1, std::numeric_limits<GLuint>::max()));
npm ERR!       |                                                                         ^
npm ERR! ../angle/src/libANGLE/HandleAllocator.cpp:29:76: error: ‘::max’ has not been declared; did you mean ‘std::max’?
npm ERR!    29 |     mUnallocatedList.push_back(HandleRange(1, std::numeric_limits<GLuint>::max()));
npm ERR!       |                                                                            ^~~
npm ERR!       |                                                                            std::max
npm ERR! In file included from /usr/include/c++/11/algorithm:62,
npm ERR!                  from ../angle/src/libANGLE/HandleAllocator.cpp:12:
npm ERR! /usr/include/c++/11/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
npm ERR!  3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
npm ERR!       |     ^~~
npm ERR! make: *** [angle/src/libANGLE.target.mk:239: Release/obj.target/libANGLE/angle/src/libANGLE/HandleAllocator.o] Error 1
npm ERR! make: *** Waiting for unfinished jobs...

[Rush]

the workaround is:

CXX=g++-10 npm install

[dhritzkiv]

@Rush Thanks for the extra detail and the workaround!

[angelsl]

That workaround, of course, depends on having GCC 10 installed.

[Rush]

Don't we all depend on things being installed? ;)

[angelsl]

Yes, but depending on your distro, having multiple GCC versions installed can be troublesome.

[qexat]

Cannot install gl at all, even with CXX=gcc++-10, it raises the same error (127) from angle/src/angle_common.target.mk:159 : Release/obj.target/angle_common/angle/src/common/Float16ToFloat32.o

[micahscopes]

I ran into this issue trying to use gpu.js, which has headless-gl as a dependency. I made a modified version of libANGLE as well as a fork of headless-gl that points to my libANGLE as a git submodule.

In my local headless-gl dev setup I'm able to get my fork to build just fine, but when I try to use my fork's git repo as a dependency i.e. using npm install https://github.com/micahscopes/headless-gl.git, it doesn't work.

The relevant error seems to be:

npm ERR! gyp: angle/src/angle.gyp not found (cwd: /home/micah/.npm/_cacache/tmp/git-clone9n6zvF) while loading dependencies of binding.gyp while trying to load binding.gyp

Is there something else I need to do besides updating the submodule to get this to work?

(Unfortunately, I'm unable to get the CXX=g++-10 npm install to work, I have the same error as @qexat.)

[micahscopes]

I also tried vendoring the libANGLE code into my fork of headless-gl, but that didn't work. But what did work was:

CXX=g++-9 npm install

😄

[qexat]

I solved my issue when I was on Ubuntu 21.10 by running this command (may not work for everyone though):

sudo apt install -y build-essential g++-10 libxi-dev libxext-dev libpixman-1-dev libcairo2-dev libpango1.0-dev libjpeg8-dev libgif-dev libjpeg-dev librsvg2-dev mesa-common-dev

I also solved it on EndeavourOS but sadly my brain does not let me remember, I'll come back when I find out again

[Luxcium]

I am now getting a different error message than previously noted in (gpujs/gpu.js#740)

Same as with CXX=gcc++-10

❯ CXX=g++-9 npm install gpu.js --save
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm ERR! code 1
npm ERR! path $HOME/.local/src/deleteme-now/node_gpu/node_modules/gl
npm ERR! command failed
npm ERR! command sh -c prebuild-install || node-gyp rebuild
npm ERR! make : on entre dans le répertoire « $HOME/.local/src/deleteme-now/node_gpu/node_modules/gl/build »
npm ERR!   CXX(target) Release/obj.target/angle_common/angle/src/common/Float16ToFloat32.o
npm ERR! make : on quitte le répertoire « $HOME/.local/src/deleteme-now/node_gpu/node_modules/gl/build »
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using node-gyp@7.1.2
npm ERR! gyp info using node@17.4.0 | linux | x64
npm ERR! gyp info find Python using Python version 3.9.7 found at "$HOME/anaconda3/bin/python3"
npm ERR! (node:129100) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
npm ERR! (Use `node --trace-deprecation ...` to show where the warning was created)
npm ERR! gyp info spawn $HOME/anaconda3/bin/python3
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args   '$HOME/.local/src/deleteme-now/node_gpu/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args   'binding.gyp',
npm ERR! gyp info spawn args   '-f',
npm ERR! gyp info spawn args   'make',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '$HOME/.local/src/deleteme-now/node_gpu/node_modules/gl/build/config.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '$HOME/.local/src/deleteme-now/node_gpu/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '$HOME/.cache/node-gyp/17.4.0/include/node/common.gypi',
npm ERR! gyp info spawn args   '-Dlibrary=shared_library',
npm ERR! gyp info spawn args   '-Dvisibility=default',
npm ERR! gyp info spawn args   '-Dnode_root_dir=$HOME/.cache/node-gyp/17.4.0',
npm ERR! gyp info spawn args   '-Dnode_gyp_dir=$HOME/.local/src/deleteme-now/node_gpu/node_modules/node-gyp',
npm ERR! gyp info spawn args   '-Dnode_lib_file=$HOME/.cache/node-gyp/17.4.0/<(target_arch)/node.lib',
npm ERR! gyp info spawn args   '-Dmodule_root_dir=$HOME/.local/src/deleteme-now/node_gpu/node_modules/gl',
npm ERR! gyp info spawn args   '-Dnode_engine=v8',
npm ERR! gyp info spawn args   '--depth=.',
npm ERR! gyp info spawn args   '--no-parallel',
npm ERR! gyp info spawn args   '--generator-output',
npm ERR! gyp info spawn args   'build',
npm ERR! gyp info spawn args   '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! gyp info spawn make
npm ERR! gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
npm ERR! make: g++-9: Aucun fichier ou dossier de ce type
npm ERR! make: *** [angle/src/angle_common.target.mk:159 : Release/obj.target/angle_common/angle/src/common/Float16ToFloat32.o] Erreur 127
npm ERR! gyp ERR! build error 
npm ERR! gyp ERR! stack Error: `make` failed with exit code: 2
npm ERR! gyp ERR! stack     at ChildProcess.onExit ($HOME/.local/src/deleteme-now/node_gpu/node_modules/node-gyp/lib/build.js:194:23)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:520:28)
npm ERR! gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12)
npm ERR! gyp ERR! System Linux 5.15.18-100.fc34.x86_64
npm ERR! gyp ERR! command "$HOME/.fnm/node-versions/v17.4.0/installation/bin/node" "$HOME/.local/src/deleteme-now/node_gpu/node_modules/.bin/node-gyp" "rebuild"
npm ERR! gyp ERR! cwd $HOME/.local/src/deleteme-now/node_gpu/node_modules/gl
npm ERR! gyp ERR! node -v v17.4.0
npm ERR! gyp ERR! node-gyp -v v7.1.2
npm ERR! gyp ERR! not ok

npm ERR! A complete log of this run can be found in:
npm ERR!     $HOME/.npm/_logs/2022-02-05T15_54_17_603Z-debug-0.log