Skip to content

Commit 1196242

Browse files
cursoragentsimbo1905
andcommitted
Issue #119 Clarify BigDecimal text-policy examples
Co-authored-by: simbo1905 <simbo1905@60hertz.com>
1 parent 2e222bd commit 1196242

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

json-java21/src/test/java/jdk/sandbox/java/util/json/DesignChoicesNumberExamplesTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,15 @@ void parseExponentFormToBigIntegerExactWorks() {
4949
void bigDecimalToJsonNumberRequiresChoosingATextPolicy() {
5050
LOGGER.info("Executing bigDecimalToJsonNumberRequiresChoosingATextPolicy");
5151

52-
var thousand = new BigDecimal("1000");
52+
// Using toPlainString() for a plain number representation
53+
var bdPlain = new BigDecimal("1000");
5354

54-
var plain = JsonNumber.of(thousand.toPlainString());
55+
var plain = JsonNumber.of(bdPlain.toPlainString());
5556
assertThat(plain.toString()).isEqualTo("1000");
5657

57-
var scientific = JsonNumber.of(new BigDecimal("1E+3").toString());
58+
// Using toString(), which may produce scientific notation
59+
var bdScientific = new BigDecimal("1E+3");
60+
var scientific = JsonNumber.of(bdScientific.toString());
5861
assertThat(scientific.toString()).isEqualTo("1E+3");
5962
}
6063

json-java21/src/test/java/jdk/sandbox/java/util/json/examples/DesignChoicesExamples.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,15 @@ public static BigInteger parseToBigIntegerExact() {
4040
}
4141

4242
public static JsonNumber bigDecimalToJsonNumberChooseTextPolicy() {
43-
var bd = new BigDecimal("1000");
43+
// Example with toPlainString() to avoid scientific notation.
44+
var bdPlain = new BigDecimal("1000");
4445

45-
var plain = JsonNumber.of(bd.toPlainString());
46+
var plain = JsonNumber.of(bdPlain.toPlainString());
4647
System.out.println("BigDecimal.toPlainString() -> JsonNumber: " + plain);
4748

48-
var scientific = JsonNumber.of(new BigDecimal("1E+3").toString());
49+
// Example with toString(), which may use scientific notation.
50+
var bdScientific = new BigDecimal("1E+3");
51+
var scientific = JsonNumber.of(bdScientific.toString());
4952
System.out.println("BigDecimal.toString() -> JsonNumber: " + scientific);
5053

5154
return plain;

0 commit comments

Comments
 (0)