[mypyc] Fix compilation of byteswriter_extra_ops (#20403)

Compiling byteswriter_extra_ops.c on its own fails because it uses types
from Python.h without including it so add the include directive.

It also references `BytesWriterObject` which is defined only when
`MYPYC_EXPERIMENTAL` is defined so wrap the functions with the same
`ifdef`.

Also add the explicit include of Python.h in other header files that
currently rely on the file being included above them when compiling.
Remove unused variables.

Author: p-sawicki

mypyc/lib-rt/byteswriter_extra_ops.c

@@ -3,6 +3,8 @@
 
 #include "byteswriter_extra_ops.h"
 
+#ifdef MYPYC_EXPERIMENTAL
+
 char CPyBytesWriter_Write(PyObject *obj, PyObject *value) {
     BytesWriterObject *self = (BytesWriterObject *)obj;
     const char *data;
@@ -29,3 +31,5 @@ char CPyBytesWriter_Write(PyObject *obj, PyObject *value) {
     self->len += size;
     return CPY_NONE;
 }
+
+#endif // MYPYC_EXPERIMENTAL

mypyc/lib-rt/byteswriter_extra_ops.h

@@ -1,6 +1,11 @@
 #ifndef BYTESWRITER_EXTRA_OPS_H
 #define BYTESWRITER_EXTRA_OPS_H
 
+#ifdef MYPYC_EXPERIMENTAL
+
+#include <stdint.h>
+#include <Python.h>
+
 #include "librt_strings.h"
 
 static inline CPyTagged
@@ -31,4 +36,6 @@ CPyBytesWriter_Append(PyObject *obj, uint8_t value) {
 
 char CPyBytesWriter_Write(PyObject *obj, PyObject *value);
 
+#endif // MYPYC_EXPERIMENTAL
+
 #endif

mypyc/lib-rt/function_wrapper.c

@@ -33,7 +33,6 @@ static PyObject* CPyFunction_repr(CPyFunction *op) {
 }
 
 static PyObject* CPyFunction_call(PyObject *func, PyObject *args, PyObject *kw) {
-    PyObject *result;
     CPyFunction *f = (CPyFunction *)func;
     vectorcallfunc vc = CPyFunction_func_vectorcall(f);
     assert(vc);

mypyc/lib-rt/getargs.c

@@ -437,7 +437,7 @@ static void
 skipitem(const char **p_format, va_list *p_va)
 {
     const char *format = *p_format;
-    char c = *format++;
+    format++;
 
     if (p_va != NULL) {
         (void) va_arg(*p_va, PyObject **);

mypyc/lib-rt/librt_base64.h

@@ -12,6 +12,8 @@ import_librt_base64(void)
 
 #else  // MYPYC_EXPERIMENTAL
 
+#include <Python.h>
+
 #define LIBRT_BASE64_ABI_VERSION 1
 #define LIBRT_BASE64_API_VERSION 2
 #define LIBRT_BASE64_API_LEN 4

mypyc/lib-rt/librt_internal.h

@@ -1,6 +1,8 @@
 #ifndef LIBRT_INTERNAL_H
 #define LIBRT_INTERNAL_H
 
+#include <Python.h>
+
 // ABI version -- only an exact match is compatible. This will only be changed in
 // very exceptional cases (likely never) due to strict backward compatibility
 // requirements.

mypyc/lib-rt/librt_strings.h

@@ -12,6 +12,8 @@ import_librt_strings(void)
 
 #else  // MYPYC_EXPERIMENTAL
 
+#include <Python.h>
+
 // ABI version -- only an exact match is compatible. This will only be changed in
 // very exceptional cases (likely never) due to strict backward compatibility
 // requirements.