From 440f0f1c025f838f631885c5694019dd7ac2f841 Mon Sep 17 00:00:00 2001
From: Woody Tseng <tsengwoody.tw@gmail.com>
Date: Mon, 4 Aug 2025 11:11:59 +0800
Subject: [PATCH 1/3] Fix "hide banner" button not contained within any
 landmark region

---
 src/components/Banner/index.astro | 2 +-
 src/components/Footer/index.astro | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/components/Banner/index.astro b/src/components/Banner/index.astro
index 29a0667dae..5d6f415f1e 100644
--- a/src/components/Banner/index.astro
+++ b/src/components/Banner/index.astro
@@ -6,7 +6,7 @@ const { link, title } = entry.data;
 ---
 
 <div class="banner bg-accent-color text-accent-type-color" style={{ display: 'none' }} data-title={title}>
-  <a class="banner-content" href={link} target="_blank">
+  <a class="banner-content" href={link} target="_blank" title="Opens in new tab">
     <Content />
   </a>
   <button id="hideBanner" aria-label="Hide banner"><Icon kind="close" /></button>
diff --git a/src/components/Footer/index.astro b/src/components/Footer/index.astro
index 5d3a10d439..890db15554 100644
--- a/src/components/Footer/index.astro
+++ b/src/components/Footer/index.astro
@@ -83,8 +83,8 @@ const bannerEntry = await getEntry("banner", currentLocale);
       </ul>
     </div>
   </div>
+  {bannerEntry && !bannerEntry.data.hidden && (<Banner entry={bannerEntry} />)}
 </footer>
-{bannerEntry && !bannerEntry.data.hidden && (<Banner entry={bannerEntry} />)}
 
 <style></style>
 

From 46512ac94cb3723394a956b01ee2f181967bbb37 Mon Sep 17 00:00:00 2001
From: coseeian <coseeian@coseeing.org>
Date: Thu, 1 Jan 2026 10:54:02 +0800
Subject: [PATCH 2/3] Revert "Fix "hide banner" button not contained within any
 landmark region"

This reverts commit 440f0f1c025f838f631885c5694019dd7ac2f841.
---
 src/components/Banner/index.astro | 2 +-
 src/components/Footer/index.astro | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/components/Banner/index.astro b/src/components/Banner/index.astro
index 5d6f415f1e..29a0667dae 100644
--- a/src/components/Banner/index.astro
+++ b/src/components/Banner/index.astro
@@ -6,7 +6,7 @@ const { link, title } = entry.data;
 ---
 
 <div class="banner bg-accent-color text-accent-type-color" style={{ display: 'none' }} data-title={title}>
-  <a class="banner-content" href={link} target="_blank" title="Opens in new tab">
+  <a class="banner-content" href={link} target="_blank">
     <Content />
   </a>
   <button id="hideBanner" aria-label="Hide banner"><Icon kind="close" /></button>
diff --git a/src/components/Footer/index.astro b/src/components/Footer/index.astro
index 890db15554..5d3a10d439 100644
--- a/src/components/Footer/index.astro
+++ b/src/components/Footer/index.astro
@@ -83,8 +83,8 @@ const bannerEntry = await getEntry("banner", currentLocale);
       </ul>
     </div>
   </div>
-  {bannerEntry && !bannerEntry.data.hidden && (<Banner entry={bannerEntry} />)}
 </footer>
+{bannerEntry && !bannerEntry.data.hidden && (<Banner entry={bannerEntry} />)}
 
 <style></style>
 

From 4827e21d4fd729f1ba6cff62e22ca56544a31e9b Mon Sep 17 00:00:00 2001
From: coseeian <coseeian@coseeing.org>
Date: Thu, 1 Jan 2026 11:24:11 +0800
Subject: [PATCH 3/3] feat: wrap banner in it's own footer landmark

---
 src/components/Banner/index.astro | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/components/Banner/index.astro b/src/components/Banner/index.astro
index 29a0667dae..5644620ba2 100644
--- a/src/components/Banner/index.astro
+++ b/src/components/Banner/index.astro
@@ -5,12 +5,12 @@ const { Content } = await entry.render();
 const { link, title } = entry.data;
 ---
 
-<div class="banner bg-accent-color text-accent-type-color" style={{ display: 'none' }} data-title={title}>
+<footer class="banner bg-accent-color text-accent-type-color" style={{ display: 'none' }} data-title={title} aria-label={title}>
   <a class="banner-content" href={link} target="_blank">
     <Content />
   </a>
   <button id="hideBanner" aria-label="Hide banner"><Icon kind="close" /></button>
-</div>
+</footer>
 
 <script is:inline>
 const banner = document.querySelector('.banner');