Replace DiscriminatorMapMetadata::getDefaultType() and DiscriminatorMapMetadata::setDefaultType() to property

Author: SerafimArts

src/Mapping/Driver/ArrayConfigDriver.php

@@ -159,12 +159,12 @@ class: $reflection,
             // @phpstan-ignore-next-line : Additional DbC invariant
             assert(\is_string($discriminatorConfig['otherwise']));
 
-            $discriminator->setDefaultType($this->createDiscriminatorType(
+            $discriminator->default = $this->createDiscriminatorType(
                 type: $discriminatorConfig['otherwise'],
                 class: $reflection,
                 types: $types,
                 parser: $parser,
-            ));
+            );
         }
 
         // ---------------------------------------------------------------------

src/Mapping/Metadata/DiscriminatorMapMetadata.php

@@ -24,7 +24,11 @@ public function __construct(
          * @var array<non-empty-string, TypeMetadata>
          */
         private array $map = [],
-        private ?TypeMetadata $default = null,
+        /**
+         * Gets default mapping type for transformations that do not comply
+         * with the specified mapping rules defined in {@see getMapping()}.
+         */
+        public ?TypeMetadata $default = null,
         ?int $createdAt = null,
     ) {
         parent::__construct($createdAt);
@@ -75,27 +79,6 @@ public function getMapping(): array
         return $this->map;
     }
 
-    /**
-     * Returns default mapping type for transformations that do not comply
-     * with the specified mapping rules defined in {@see getMapping()}.
-     *
-     * @api
-     */
-    public function getDefaultType(): ?TypeMetadata
-    {
-        return $this->default;
-    }
-
-    /**
-     * Updates default mapping type.
-     *
-     * @api
-     */
-    public function setDefaultType(?TypeMetadata $type): void
-    {
-        $this->default = $type;
-    }
-
     /**
      * Dynamically creates AST discriminator representation.
      *

src/Type/ClassType/ClassTypeDenormalizer.php

@@ -133,8 +133,7 @@ public function cast(mixed $value, Context $context): mixed
     private function castOverDiscriminator(DiscriminatorMapMetadata $map, array $value, Context $context): mixed
     {
         // Default mapping type
-        $default = $map->getDefaultType()
-            ?->type;
+        $default = $map->default?->type;
 
         $field = $map->field;
 

tests/Mapping/Metadata/DiscriminatorMapMetadataTest.php

@@ -18,7 +18,7 @@ public function testBasics(): void
         $m = new DiscriminatorMapMetadata('kind');
         self::assertSame('kind', $m->field);
         self::assertSame([], $m->getMapping());
-        self::assertNull($m->getDefaultType());
+        self::assertNull($m->default);
         self::assertFalse($m->hasType('x'));
         self::assertNull($m->findType('x'));
     }
@@ -44,10 +44,10 @@ public function testDefaultType(): void
         $tm = new TypeMetadata($type, $stmt);
 
         $m = new DiscriminatorMapMetadata('kind');
-        $m->setDefaultType($tm);
-        self::assertSame($tm, $m->getDefaultType());
+        $m->default = $tm;
+        self::assertSame($tm, $m->default);
 
-        $m->setDefaultType(null);
-        self::assertNull($m->getDefaultType());
+        $m->default = null;
+        self::assertNull($m->default);
     }
 }