[FSSDK-11964] chore: update GitHub Actions to macOS 15 runner with Xcode 16 (#615)

* Updated to macos 15

* update simulator version

* docs: update workflow and script configuration

* clean up

Author: muzahidul-opti

.github/workflows/source_clear_cron.yml

@@ -9,12 +9,12 @@ on:
 
 jobs:
   source_clear:
-    runs-on: macos-13
+    runs-on: macos-15
     steps:
       - uses: actions/checkout@v3
       - name: Source clear scan
         env:
           SRCCLR_API_TOKEN: ${{ secrets.SRCCLR_API_TOKEN }}
         run: |
-          gem install cocoapods -v '1.9.3'
+          gem install cocoapods -v '1.15.2'
           curl -sSL https://download.sourceclear.com/ci.sh | bash -s - scan

.github/workflows/swift.yml

@@ -31,12 +31,12 @@ jobs:
       CI_USER_TOKEN: ${{ secrets.CI_USER_TOKEN }}
 
   lint: 
-    runs-on: macos-13
+    runs-on: macos-15
     steps:
     - uses: actions/checkout@v3
     - uses: maxim-lobanov/setup-xcode@v1
       with:
-        xcode-version: 14.1.0
+        xcode-version: 16.1.0
     - env:
         SRCCLR_API_TOKEN: ${{ secrets.SRCCLR_API_TOKEN }}
       run: |
@@ -48,13 +48,13 @@ jobs:
     if: "${{ github.event.inputs.PREP == '' && github.event.inputs.RELEASE == '' }}" 
     uses: optimizely/swift-sdk/.github/workflows/unit_tests.yml@master
   prepare_for_release:
-    runs-on: macos-13
+    runs-on: macos-15
     if: "${{ github.event.inputs.PREP == 'true' && github.event_name == 'workflow_dispatch' }}" 
     steps:
     - uses: actions/checkout@v3
     - uses: maxim-lobanov/setup-xcode@v1
       with:
-        xcode-version: 14.1.0
+        xcode-version: 16.1.0
     - name: Install Hub by Homebrew
       run: |
         /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
@@ -77,12 +77,12 @@ jobs:
 
   release:
     if: "${{github.event.inputs.RELEASE == 'true' && github.event_name == 'workflow_dispatch' }}"
-    runs-on: macos-13
+    runs-on: macos-15
     steps:
     - uses: actions/checkout@v3
     - uses: maxim-lobanov/setup-xcode@v1
       with:
-        xcode-version: 14.1.0
+        xcode-version: 16.1.0
     - name: Install Hub by Homebrew
       run: |
         /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"

.github/workflows/unit_tests.yml

@@ -7,7 +7,7 @@ env:
 
 jobs:
   unittests:
-    runs-on: macos-13
+    runs-on: macos-15
     strategy:
       fail-fast: false
       matrix:
@@ -16,43 +16,42 @@ jobs:
         # - each xcode version has own simulator os versions.
         # - so to run tests with the target simulator, we have to find a proper xcode version pre-installed and support the target simulator os version.
         #   also, the xcode version (simulator_xcode_version) and simulator os versions (os) are moving target. We have to change these time to time.
-        # - see "https://github.com/actions/runner-images/blob/main/images/macos/macos-11-Readme.md" for installed macOS, xcode and simulator versions.
+        # - see "https://github.com/actions/runner-images/blob/main/images/macos/macos-15-Readme.md" for installed macOS, xcode and simulator versions.
         include:
-          - os: 16.1
-            device: "iPhone 14"
+          - os: 18.4
+            device: "iPhone 16"
             scheme: "OptimizelySwiftSDK-iOS"
             test_sdk: "iphonesimulator"
             platform: "iOS Simulator"
             os_type: "iOS"
-            simulator_xcode_version: 14.1
-          - os: 16.2
-            device: "iPhone 14"
+            simulator_xcode_version: 16.3
+          - os: 18.5
+            device: "iPhone 16 Plus"
             scheme: "OptimizelySwiftSDK-iOS"
             test_sdk: "iphonesimulator"
             platform: "iOS Simulator"
             os_type: "iOS"
-            simulator_xcode_version: 14.2
-          - os: 16.4
-            # good to have tests with older OS versions, but it looks like this is min OS+xcode versions supported by github actions
-            device: "iPad Air (5th generation)"
+            simulator_xcode_version: 16.4
+          - os: 18.6
+            device: "iPad Air 11-inch (M2)"
             scheme: "OptimizelySwiftSDK-iOS"
             test_sdk: "iphonesimulator"
             platform: "iOS Simulator"
             os_type: "iOS"
-            simulator_xcode_version: 14.3.1
-          - os: 16.1
+            simulator_xcode_version: 16.4
+          - os: 18.5
             device: "Apple TV"
             scheme: "OptimizelySwiftSDK-tvOS"
             test_sdk: "appletvsimulator"
             platform: "tvOS Simulator"
             os_type: "tvOS"
-            simulator_xcode_version: 14.1
+            simulator_xcode_version: 16.4
     steps:
       - uses: actions/checkout@v3
       - uses: maxim-lobanov/setup-xcode@v1
         with:
           # macos version and supported simulator_xcode_versions are all related to this xcode_version, so be careful when you upgrade this.
-          xcode-version: 14.1
+          xcode-version: 16.4
       - name: set SDK Branch if PR
         env:
           BASE_REF: ${{ github.base_ref }}
@@ -98,11 +97,11 @@ jobs:
         with:
           name: build-logs-${{ matrix.device }}-${{ matrix.os }}
           path: build/Logs
-      - # - report coverage for PR and iPhone 11 only (avoid redundant ones)
-        # - use Xcode12.4+ (older Xcode reports a wrong number)
+      - # - report coverage for PR and iPhone 16 only (avoid redundant ones)
+        # - use Xcode16+ (older Xcode reports a wrong number)
         name: Check on success
         id: coveralls
-        if: ${{ steps.unit_tests.outcome == 'success' && env.BRANCH == 'master' && env.PLATFORM == 'iOS Simulator' && env.NAME == 'iPhone 11' }}
+        if: ${{ steps.unit_tests.outcome == 'success' && env.BRANCH == 'master' && env.PLATFORM == 'iOS Simulator' && env.NAME == 'iPhone 16' }}
         env:
           PLATFORM: ${{ matrix.platform }}
           NAME: ${{ matrix.device }}

Scripts/prepare_simulator.sh

@@ -41,8 +41,44 @@ if [ "$MAJOR_SIMULATOR_XCODE_VERSION" -lt 12 ]; then
     xcrun simctl create "custom-device" "com.apple.CoreSimulator.SimDeviceType.$name" "com.apple.CoreSimulator.SimRuntime.$OS_TYPE-$os"
     CUSTOM_SIMULATOR="$(instruments -s devices | grep -m 1 'custom-device' | awk -F'[][]' '{print $2}')"
 else
-    echo ".devices.\"com.apple.CoreSimulator.SimRuntime.${PLATFORM/ Simulator/}-${OS/./-}\"" > /tmp/jq_file
-    CUSTOM_SIMULATOR=$( xcrun simctl list --json devices | jq -f /tmp/jq_file | jq -r '.[] | select(.name==env.NAME) | .udid' )
+    # For Xcode 16+, try multiple runtime key formats
+    # The runtime key format has changed over Xcode versions
+    RUNTIME_KEY1="com.apple.CoreSimulator.SimRuntime.${PLATFORM/ Simulator/}-${OS/./-}"
+    RUNTIME_KEY2="${PLATFORM/ Simulator/}-${OS/./-}"
+
+    # echo "Attempting to find simulator: $NAME with OS: $OS"
+    # echo "Runtime key 1: $RUNTIME_KEY1"
+    # echo "Runtime key 2: $RUNTIME_KEY2"
+
+    # List all available devices for debugging
+    # echo "Available device runtimes:"
+    # xcrun simctl list --json devices | jq -r '.devices | keys[]'
+
+    # Try format 1: com.apple.CoreSimulator.SimRuntime.iOS-XX-X
+    echo ".devices.\"$RUNTIME_KEY1\"" > /tmp/jq_file
+    CUSTOM_SIMULATOR=$( xcrun simctl list --json devices | jq -f /tmp/jq_file 2>/dev/null | jq -r '.[]? | select(.name==env.NAME) | .udid' || echo "" )
+
+    # If not found, try format 2: iOS-XX-X
+    if [ -z "$CUSTOM_SIMULATOR" ]; then
+        echo "Trying alternative runtime key format..."
+        echo ".devices.\"$RUNTIME_KEY2\"" > /tmp/jq_file
+        CUSTOM_SIMULATOR=$( xcrun simctl list --json devices | jq -f /tmp/jq_file 2>/dev/null | jq -r '.[]? | select(.name==env.NAME) | .udid' || echo "" )
+    fi
+
+    # If still not found, search all runtimes
+    if [ -z "$CUSTOM_SIMULATOR" ]; then
+        echo "Searching all runtimes for device: $NAME"
+        CUSTOM_SIMULATOR=$( xcrun simctl list --json devices | jq -r --arg os "$OS" --arg name "$NAME" '.devices | to_entries[] | select(.key | contains($os)) | .value[] | select(.name==$name) | .udid' | head -n 1 )
+    fi
+
+    if [ -z "$CUSTOM_SIMULATOR" ]; then
+        echo "ERROR: Could not find simulator '$NAME' with OS version $OS"
+        echo "Available devices:"
+        xcrun simctl list devices available
+        exit 1
+    fi
+
+    echo "Found simulator: $CUSTOM_SIMULATOR"
 fi
 xcrun simctl boot $CUSTOM_SIMULATOR && sleep 30
 xcrun simctl list | grep Booted