[IMP] estate: ignore button click when the property is already cancelled

Ignore the button click to mark a property as cancelled if the property is already cancelled. This is more user-friendly than raising an error.

Author: robal-odoo

estate/models/estate_property.py

@@ -85,12 +85,12 @@ def action_set_sold(self) -> bool:
 
     def action_set_cancelled(self) -> bool:
         for record in self:
+            if record.state == "cancelled":
+                continue
+
             if record.state == "sold":
                 raise UserError(_("Sold properties cannot be cancelled."))
 
-            if record.state == "cancelled":
-                raise UserError(_("This property has already been cancelled."))
-
             record.state = "cancelled"
         return True