[FIX] estate: replace invalid models.Constraint with _sql_constraints

raibr · raibr · commit 806e10358fc7 · 2025-12-19T09:43:25.000+01:00
The models.Constraint syntax does not exist in Odoo's ORM.
SQL constraints must be defined using the _sql_constraints class attribute.
diff --git a/.gitignore b/.gitignore
@@ -127,4 +127,3 @@ dmypy.json
 
 # Pyre type checker
 .pyre/
-.DS_Store
diff --git a/README-raibr-docs.md b/README-raibr-docs.md
diff --git a/estate/__manifest__.py b/estate/__manifest__.py
@@ -1,12 +1,11 @@
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 {
-    'name': 'Real Estate Advertisement',
-    'version': '1.0',
-    'author': 'Odoo',
-    'category': 'Sales/Real Estate',
-    'sequence': 15,
-    'summary': 'Manage property listings and real estate advertisements',
-    'description': """
+    "name": "Real Estate Advertisement",
+    "author": "Odoo",
+    "category": "Sales/Real Estate",
+    "sequence": 15,
+    "summary": "Manage property listings and real estate advertisements",
+    "description": """
 Real Estate Advertisement Management
 ====================================
 This module allows you to manage real estate properties, including:
@@ -15,16 +14,15 @@
     * Property offers and negotiations
     * Sales tracking
     """,
-    'depends': ['base'],
-    'data': [
-        'security/ir.model.access.csv',
-        'views/estate_property_views.xml',
-        'views/estate_property_type_views.xml',
-        'views/estate_property_tag_views.xml',
-        'views/estate_property_offer_views.xml',
-        'views/estate_menus.xml',
+    "depends": ["base"],
+    "data": [
+        "security/ir.model.access.csv",
+        "views/estate_property_views.xml",
+        "views/estate_property_offer_views.xml",
+        "views/estate_property_type_views.xml",
+        "views/estate_property_tag_views.xml",
+        "views/estate_menus.xml",
     ],
-    'installable': True,
-    'application': True,
-    'license': 'LGPL-3',
+    "application": True,
+    "license": "LGPL-3",
 }
diff --git a/estate/models/estate_property.py b/estate/models/estate_property.py
@@ -1,63 +1,73 @@
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
 from odoo import api, fields, models
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools.float_utils import float_compare, float_is_zero
 
 
 class EstateProperty(models.Model):
-    _name = "estate.property"
+    _name = 'estate.property'
     _description = "Real Estate Property"
+    _order = 'id desc'
+    _check_expected_price = models.Constraint('Check(expected_price > 0)', "The expected price must be strictly positive.")
+    _check_selling_price = models.Constraint('Check(selling_price >= 0)', "The selling price must be positive.")
 
-    name = fields.Char(required=True)
-    description = fields.Text()
-    postcode = fields.Char()
-    date_availability = fields.Date()
-    expected_price = fields.Float()
-    selling_price = fields.Float()
-    bedrooms = fields.Integer()
-    living_area = fields.Integer()
-    facades = fields.Integer()
-    garage = fields.Boolean()
-    garden = fields.Boolean()
-    garden_area = fields.Integer()
+    name = fields.Char(required=True, string="Name")
+    description = fields.Text(string="Description")
+    postcode = fields.Char(string="Postcode")
+    date_availability = fields.Date(string="Available From")
+    expected_price = fields.Float(required=True, string="Expected Price")
+    selling_price = fields.Float(string="Selling Price")
+    bedrooms = fields.Integer(string="Bedrooms")
+    living_area = fields.Integer(string="Living Area (sqm)")
+    facades = fields.Integer(string="Facades")
+    garage = fields.Boolean(string="Garage")
+    garden = fields.Boolean(string="Garden")
+    garden_area = fields.Integer(string="Garden Area (sqm)")
     garden_orientation = fields.Selection(
         selection=[
-            ('north', 'North'),
-            ('south', 'South'),
-            ('east', 'East'),
-            ('west', 'West')
-        ]
+            ('north', "North"),
+            ('south', "South"),
+            ('east', "East"),
+            ('west', "West"),
+        ],
+        string="Garden Orientation",
     )
     state = fields.Selection(
         selection=[
-            ('new', 'New'),
-            ('offer_received', 'Offer Received'),
-            ('offer_accepted', 'Offer Accepted'),
-            ('sold', 'Sold'),
-            ('cancelled', 'Cancelled')
+            ('new', "New"),
+            ('offer_received', "Offer Received"),
+            ('offer_accepted', "Offer Accepted"),
+            ('sold', "Sold"),
+            ('cancelled', "Cancelled"),
         ],
         default='new',
-        required=True
+        required=True,
+        string="Status",
+    )
+    buyer_id = fields.Many2one(comodel_name='res.partner', string="Buyer")
+    property_type_id = fields.Many2one(comodel_name='estate.property.type', string="Property Type")
+    tag_ids = fields.Many2many(comodel_name='estate.property.tag', string="Tags")
+    offer_ids = fields.One2many(
+        comodel_name='estate.property.offer',
+        inverse_name='property_id',
+        string="Offers",
     )
-    buyer_id = fields.Many2one('res.partner', string='Buyer')
-    property_type_id = fields.Many2one("estate.property.type", string="Property Type")
-    tag_ids = fields.Many2many("estate.property.tag", string="Tags")
-    offer_ids = fields.One2many("estate.property.offer", "property_id", string="Offers")
-    total_area = fields.Integer(compute="_compute_total_area")
-    best_price = fields.Float(compute="_compute_best_price", string="Best Offer Price")
+    total_area = fields.Integer(compute='_compute_total_area', string="Total Area (sqm)")
+    best_price = fields.Float(compute='_compute_best_price', string="Best Offer Price")
 
     @api.depends('living_area', 'garden_area')
     def _compute_total_area(self):
-        for record in self:
-            record.total_area = record.living_area + record.garden_area
+        for property in self:
+            property.total_area = property.living_area + property.garden_area
 
     @api.depends('offer_ids.price')
     def _compute_best_price(self):
-        for record in self:
-            if record.offer_ids:
-                record.best_price = max(record.offer_ids.mapped('price'))
+        for property in self:
+            if property.offer_ids:
+                property.best_price = max(property.offer_ids.mapped('price'))
             else:
-                record.best_price = 0.0
+                property.best_price = 0.0
 
     @api.onchange('garden')
     def _onchange_garden(self):
@@ -68,16 +78,23 @@ def _onchange_garden(self):
             self.garden_area = 0
             self.garden_orientation = False
 
+    @api.constrains('selling_price', 'expected_price')
+    def _check_selling_price(self):
+        for property in self:
+            if not float_is_zero(property.selling_price, precision_digits=2):
+                if float_compare(property.selling_price, property.expected_price * 0.9, precision_digits=2) < 0:
+                    raise ValidationError(self.env._("The selling price cannot be lower than 90% of the expected price."))
+
     def action_sold(self):
-        for record in self:
-            if record.state == 'cancelled':
-                raise UserError("Cancelled property cannot be sold.")
-            record.state = 'sold'
+        for property in self:
+            if property.state == 'cancelled':
+                raise UserError(self.env._("Cancelled property cannot be sold."))
+            property.state = 'sold'
         return True
 
     def action_cancel(self):
-        for record in self:
-            if record.state == 'sold':
-                raise UserError("Sold property cannot be cancelled.")
-            record.state = 'cancelled'
+        for property in self:
+            if property.state == 'sold':
+                raise UserError(self.env._("Sold property cannot be cancelled."))
+            property.state = 'cancelled'
         return True
diff --git a/estate/models/estate_property_offer.py b/estate/models/estate_property_offer.py
@@ -6,48 +6,52 @@
 
 
 class EstatePropertyOffer(models.Model):
-    _name = "estate.property.offer"
+    _name = 'estate.property.offer'
     _description = "Real Estate Property Offer"
-    _order = "price desc"
-
-    price = fields.Float(required=True)
-    status = fields.Selection(
-        selection=[
-            ('accepted', 'Accepted'),
-            ('refused', 'Refused')
-        ],
-        copy=False
-    )
-    partner_id = fields.Many2one('res.partner', string='Partner', required=True)
-    property_id = fields.Many2one("estate.property", string="Property", required=True)
+    _order = 'price desc'
+
+    price = fields.Float(required=True, string="Price")
+    _check_price = models.Constraint('Check(price > 0)', "The offer price must be strictly positive.")
+    status = fields.Selection(selection=[('accepted', "Accepted"), ('refused', "Refused")], copy=False, string="Status")
+    partner_id = fields.Many2one(comodel_name='res.partner', string="Partner", required=True)
+    property_id = fields.Many2one(comodel_name='estate.property', string="Property", required=True)
     validity = fields.Integer(default=7, string="Validity (days)")
     date_deadline = fields.Date(
-        compute="_compute_date_deadline",
-        inverse="_inverse_date_deadline",
+        compute='_compute_date_deadline',
+        inverse='_inverse_date_deadline',
         store=True,
         string="Deadline",
     )
 
-    @api.depends("validity")
+    # self.property_id.status = 'offer_received' when offer is created
+    @api.model
+    def create(self, vals):
+        offer = super().create(vals)
+        if offer.property_id.state == 'new':
+            offer.property_id.state = 'offer_received'
+        return offer
+
+    @api.depends('validity')
     def _compute_date_deadline(self):
-        for record in self:
-            record.date_deadline = fields.Date.today() + timedelta(days=record.validity)
+        for offer in self:
+            offer.date_deadline = fields.Date.today() + timedelta(days=offer.validity)
 
     def _inverse_date_deadline(self):
-        for record in self:
-            if record.date_deadline:
-                record.validity = (record.date_deadline - fields.Date.today()).days
+        for offer in self:
+            if offer.date_deadline:
+                offer.validity = (offer.date_deadline - fields.Date.today()).days
 
     def action_accept(self):
-        for record in self:
-            if record.property_id.offer_ids.filtered(lambda o: o.status == 'accepted' and o.id != record.id):
-                raise UserError("Only one offer can be accepted per property.")
-            record.status = 'accepted'
-            record.property_id.buyer_id = record.partner_id
-            record.property_id.selling_price = record.price
+        for offer in self:
+            if offer.property_id.offer_ids.filtered(lambda o: o.status == 'accepted' and o.id != offer.id):
+                raise UserError(self.env._("Only one offer can be accepted per property."))
+            offer.status = 'accepted'
+            offer.property_id.buyer_id = offer.partner_id
+            offer.property_id.selling_price = offer.price
+            offer.property_id.state = 'offer_accepted'
         return True
 
     def action_refuse(self):
-        for record in self:
-            record.status = 'refused'
+        for offer in self:
+            offer.status = 'refused'
         return True
diff --git a/estate/models/estate_property_tag.py b/estate/models/estate_property_tag.py
@@ -4,8 +4,11 @@
 
 
 class EstatePropertyTag(models.Model):
-    _name = "estate.property.tag"
+    _name = 'estate.property.tag'
     _description = "Real Estate Property Tag"
-    _order = "name"
+    _order = 'name'
 
-    name = fields.Char(required=True)
+    _check_unique_name = models.Constraint('UNIQUE(name)', "The tag name must be unique.")
+
+    name = fields.Char(required=True, string="Name")
+    color = fields.Integer(string="Color")
diff --git a/estate/models/estate_property_type.py b/estate/models/estate_property_type.py
@@ -4,8 +4,16 @@
 
 
 class EstatePropertyType(models.Model):
-    _name = "estate.property.type"
+    _name = 'estate.property.type'
     _description = "Real Estate Property Type"
-    _order = "name"
+    _order = 'name'
+    _check_unique_name = models.Constraint('UNIQUE(name)', "The type name must be unique.")
 
-    name = fields.Char(required=True)
+    name = fields.Char(required=True, string="Name")
+    sequence = fields.Integer(default=1, string="Sequence")
+    property_ids = fields.One2many(comodel_name='estate.property', inverse_name='property_type_id', string="Properties")
+    offer_count = fields.Integer(compute='_compute_offer_count', string="Offer Count")
+
+    def _compute_offer_count(self):
+        for property_type in self:
+            property_type.offer_count = sum(property_type.property_ids.mapped(lambda p: len(p.offer_ids)))
diff --git a/estate/views/estate_property_offer_views.xml b/estate/views/estate_property_offer_views.xml
@@ -1,18 +1,20 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
-    <!-- Tree View -->
-    <record id="estate_property_offer_view_tree" model="ir.ui.view">
-        <field name="name">estate.property.offer.view.tree</field>
+    <!-- List View -->
+    <record id="estate_property_offer_view_list" model="ir.ui.view">
+        <field name="name">estate.property.offer.view.list</field>
         <field name="model">estate.property.offer</field>
         <field name="arch" type="xml">
-            <list>
+            <list editable="bottom" decoration-danger="status == 'refused'" decoration-success="status == 'accepted'">
                 <field name="price"/>
                 <field name="partner_id"/>
+                <field name="property_id"/>
                 <field name="validity"/>
                 <field name="date_deadline"/>
-                <field name="status"/>
+                <field name="status" column_invisible="1"/>
                 <button name="action_accept" type="object" icon="fa-check" title="Accept"/>
                 <button name="action_refuse" type="object" icon="fa-times" title="Refuse"/>
+                
             </list>
         </field>
     </record>
@@ -42,5 +44,6 @@
         <field name="name">Property Offers</field>
         <field name="res_model">estate.property.offer</field>
         <field name="view_mode">list,form</field>
+        <field name="domain">[('property_id.property_type_id', '=', active_id)]</field>
     </record>
 </odoo>
diff --git a/estate/views/estate_property_tag_views.xml b/estate/views/estate_property_tag_views.xml
@@ -1,11 +1,11 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
     <!-- List view -->
-    <record id="estate_property_tag_view_tree" model="ir.ui.view">
-        <field name="name">estate.property.tag.view.tree</field>
+    <record id="estate_property_tag_view_list" model="ir.ui.view">
+        <field name="name">estate.property.tag.view.list</field>
         <field name="model">estate.property.tag</field>
         <field name="arch" type="xml">
-            <list string="Property Tags">
+            <list string="Property Tags" editable="bottom">
                 <field name="name"/>
             </list>
         </field>
diff --git a/estate/views/estate_property_type_views.xml b/estate/views/estate_property_type_views.xml
diff --git a/estate/views/estate_property_views.xml b/estate/views/estate_property_views.xml

Original file line number	Diff line number	Diff line change
`@@ -127,4 +127,3 @@ dmypy.json`
`127`	`127`
`128`	`128`	`# Pyre type checker`
`129`	`129`	`.pyre/`
`130`		`-.DS_Store`