[FIX] estate: use translation method for error messages

Author: robal-odoo

estate/models/estate_property.py

@@ -1,5 +1,5 @@
 from dateutil.relativedelta import relativedelta
-from odoo import api, fields, models
+from odoo import api, fields, models, _
 from odoo.exceptions import UserError, ValidationError
 from odoo.tools.float_utils import float_compare, float_is_zero
 
@@ -69,32 +69,27 @@ def _compute_garden_defaults(self) -> None:
     @api.ondelete(at_uninstall=False)
     def _unlink_except_new_or_cancelled(self) -> None:
         if any(record.state not in {"new", "cancelled"} for record in self):
-            error_msg = "Cannot delete properties unless they are new or cancelled."
-            raise UserError(error_msg)
+            raise UserError(_("Cannot delete properties unless they are new or cancelled."))
 
     # Public methods
     def action_set_sold(self) -> bool:
         for record in self:
             if record.state == "sold":
-                error_msg = "This property has already been sold."
-                raise UserError(error_msg)
+                raise UserError(_("This property has already been sold."))
 
             if record.state == "cancelled":
-                error_msg = "Cancelled properties cannot be sold."
-                raise UserError(error_msg)
+                raise UserError(_("Cancelled properties cannot be sold."))
 
             record.state = "sold"
         return True
 
     def action_set_cancelled(self) -> bool:
         for record in self:
             if record.state == "sold":
-                error_msg = "Sold properties cannot be cancelled."
-                raise UserError(error_msg)
+                raise UserError(_("Sold properties cannot be cancelled."))
 
             if record.state == "cancelled":
-                error_msg = "This property has already been cancelled."
-                raise UserError(error_msg)
+                raise UserError(_("This property has already been cancelled."))
 
             record.state = "cancelled"
         return True
@@ -115,5 +110,4 @@ def _restrict_selling_price(self) -> None:
         for record in self:
             # Selling price is zero when no offer has been accepted
             if not float_is_zero(record.selling_price, precision_digits=2) and float_compare(record.selling_price, 0.9 * record.expected_price, precision_digits=2) < 0:
-                error_msg = "A property's selling price cannot be lower that 90 percent of its expected price."
-                raise ValidationError(error_msg)
+                raise ValidationError(_("A property's selling price cannot be lower that 90 percent of its expected price."))

estate/models/estate_property_offer.py

@@ -1,7 +1,7 @@
 from datetime import date
 
 from dateutil.relativedelta import relativedelta
-from odoo import api, fields, models
+from odoo import api, fields, models, _
 from odoo.exceptions import UserError
 
 
@@ -40,8 +40,7 @@ def create(self, vals):
         for val in vals:
             estate_property = self.env["estate.property"].browse(val["property_id"])
             if val["price"] < estate_property.best_price:
-                error_msg = f"Cannot create an offer with an price that's lower than the current best offer: {estate_property.best_price}"
-                raise UserError(error_msg)
+                raise UserError(_("A new offer must match or exceed the price of the current best offer."))
             estate_property.state = "offer_received"
         return super().create(vals)
 
@@ -50,12 +49,10 @@ def action_accept(self) -> bool:
         # TODO validation
         for record in self:
             if record.status == "accepted":
-                error_msg = "This offer has already been accepted."
-                raise UserError(error_msg)
+                raise UserError(_("This offer has already been accepted."))
 
             if record.property_id.offer_ids.filtered(lambda r: r.status == "accepted"):
-                error_msg = "Cannot accept this offer because another offer has already been accepted for the property."
-                raise UserError(error_msg)
+                raise UserError(_("Cannot accept this offer because another offer has already been accepted for the property."))
 
             record.status = "accepted"
             record.property_id.selling_price = record.price