From c2c84974be29c2f4b618f5fc67de867bdf79e781 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Mon, 9 Feb 2026 15:11:04 +0100 Subject: [PATCH] crypto: always return certificate serial numbers as uppercase This hides a discrepancy between OpenSSL and BoringSSL, as the latter returns lowercase hex values. Refs: https://github.com/nodejs/node/pull/61459#discussion_r2713110952 --- src/crypto/crypto_x509.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/crypto/crypto_x509.cc b/src/crypto/crypto_x509.cc index 11622d823bbc0a..f40f6dd4f2bcaf 100644 --- a/src/crypto/crypto_x509.cc +++ b/src/crypto/crypto_x509.cc @@ -253,8 +253,8 @@ MaybeLocal GetSignatureAlgorithmOID(Environment* env, MaybeLocal GetSerialNumber(Environment* env, const X509View& view) { if (auto serial = view.getSerialNumber()) { - return OneByteString(env->isolate(), - static_cast(serial.get())); + return ToV8Value( + env, ToUpper(std::string_view(static_cast(serial.get())))); } return Undefined(env->isolate()); }