Chaining scopes with ODBC is bugged: disabling the test.

It may check the previous transaction during enlistment, without guarding against it being disposed.

Author: fredericDelaporte

src/NHibernate.Test/Async/SystemTransactions/SystemTransactionFixture.cs

@@ -14,6 +14,7 @@
 using System.Threading;
 using System.Transactions;
 using NHibernate.Cfg;
+using NHibernate.Driver;
 using NHibernate.Engine;
 using NHibernate.Linq;
 using NHibernate.Test.TransactionTest;
@@ -186,6 +187,12 @@ public async Task CanDeleteItemAsync(bool explicitFlush)
 		public async Task CanUseSessionWithManyScopesAsync(bool explicitFlush)
 		{
 			IgnoreIfUnsupported(explicitFlush);
+			// ODBC with SQL-Server always causes scopes to go distributed, which causes their transaction completion to run
+			// asynchronously. But ODBC enlistment also check the previous transaction in a way that do not guard against it
+			// being concurrently disposed of. See https://github.com/nhibernate/nhibernate-core/pull/1505 for more details.
+			Assume.That(!(Sfi.ConnectionProvider.Driver is OdbcDriver),
+			            "ODBC sometimes fails on second scope by checking the previous transaction status, which may yield an object disposed exception");
+
 			using (var s = WithOptions().ConnectionReleaseMode(ConnectionReleaseMode.OnClose).OpenSession())
 			{
 				using (var tx = new TransactionScope(TransactionScopeAsyncFlowOption.Enabled))
@@ -529,4 +536,4 @@ public class SystemTransactionWithoutAutoJoinTransactionAsync : SystemTransactio
 	{
 		protected override bool AutoJoinTransaction => false;
 	}
-}
+}

src/NHibernate.Test/SystemTransactions/SystemTransactionFixture.cs

@@ -4,6 +4,7 @@
 using System.Threading;
 using System.Transactions;
 using NHibernate.Cfg;
+using NHibernate.Driver;
 using NHibernate.Engine;
 using NHibernate.Linq;
 using NHibernate.Test.TransactionTest;
@@ -175,6 +176,12 @@ public void CanDeleteItem(bool explicitFlush)
 		public void CanUseSessionWithManyScopes(bool explicitFlush)
 		{
 			IgnoreIfUnsupported(explicitFlush);
+			// ODBC with SQL-Server always causes scopes to go distributed, which causes their transaction completion to run
+			// asynchronously. But ODBC enlistment also check the previous transaction in a way that do not guard against it
+			// being concurrently disposed of. See https://github.com/nhibernate/nhibernate-core/pull/1505 for more details.
+			Assume.That(!(Sfi.ConnectionProvider.Driver is OdbcDriver),
+			            "ODBC sometimes fails on second scope by checking the previous transaction status, which may yield an object disposed exception");
+
 			using (var s = WithOptions().ConnectionReleaseMode(ConnectionReleaseMode.OnClose).OpenSession())
 			{
 				using (var tx = new TransactionScope())
@@ -539,4 +546,4 @@ public void SessionIsNotEnlisted()
 			}
 		}
 	}
-}
+}