Merge branch 'JKeyser-NH3487'

Author: oskarb

src/NHibernate.Test/NHSpecificTest/NH3487/Entity.cs

@@ -0,0 +1,48 @@
+using System;
+
+namespace NHibernate.Test.NHSpecificTest.NH3487
+{
+	[Serializable]
+	public class Entity
+	{
+		public virtual Key Id { get; set; }
+		public virtual string Name { get; set; }
+
+		public override bool Equals(object obj)
+		{
+			var otherEntity = obj as Entity;
+			if (otherEntity != null)
+			{
+				return otherEntity.Id.Equals(Id);
+			}
+			return false;
+		}
+
+		public override int GetHashCode()
+		{
+			return Id.GetHashCode();
+		}
+	}
+
+	[Serializable]
+	public class Key
+	{
+		public virtual int Id { get; set; }
+
+		public override bool Equals(object obj)
+		{
+			var otherEntity = obj as Key;
+			if (otherEntity != null)
+			{
+				return otherEntity.Id == Id;
+			}
+			return false;
+		}
+
+		public override int GetHashCode()
+		{
+			// Important to reproduce the problem - forces the keys to collide in the hash map
+			return 1;
+		}
+	}
+}

src/NHibernate.Test/NHSpecificTest/NH3487/Fixture.cs

@@ -0,0 +1,83 @@
+using System.IO;
+using System.Runtime.Serialization;
+using System.Runtime.Serialization.Formatters.Binary;
+using NUnit.Framework;
+
+namespace NHibernate.Test.NHSpecificTest.NH3487
+{
+	[TestFixture]
+	public class Fixture : BugTestCase
+	{
+		private Key _key1;
+		private Key _key2;
+
+		public override string BugNumber
+		{
+			get { return "NH3487"; }
+		}
+
+		protected override void OnSetUp()
+		{
+			using (ISession session = OpenSession())
+			{
+				using (ITransaction transaction = session.BeginTransaction())
+				{
+					_key1 = new Key {Id = 1};
+					var entity1 = new Entity {Id = _key1, Name = "Bob1"};
+					session.Save(entity1);
+
+					_key2 = new Key {Id = 2};
+					var entity2 = new Entity {Id = _key2, Name = "Bob2"};
+					session.Save(entity2);
+
+					session.Flush();
+					transaction.Commit();
+				}
+			}
+		}
+
+		protected override void OnTearDown()
+		{
+			using (ISession session = OpenSession())
+			{
+				using (ITransaction transaction = session.BeginTransaction())
+				{
+					session.Delete("from System.Object");
+
+					session.Flush();
+					transaction.Commit();
+				}
+			}
+		}
+
+		[Test]
+		public void CanDeserializeSessionWithEntityHashCollision()
+		{
+			IFormatter formatter = new BinaryFormatter();
+			byte[] serializedSessionArray;
+
+			using (ISession session = OpenSession())
+			{
+				using (session.BeginTransaction())
+				{
+					session.Get<Entity>(_key1);
+					session.Get<Entity>(_key2);
+				}
+
+				session.Disconnect();
+				using (var serializationStream = new MemoryStream())
+				{
+					formatter.Serialize(serializationStream, session);
+					serializationStream.Close();
+					serializedSessionArray = serializationStream.ToArray();
+				}
+			}
+
+			using (var serializationStream = new MemoryStream(serializedSessionArray))
+			{
+				formatter.Deserialize(serializationStream);
+			}
+
+		}
+	}
+}

src/NHibernate.Test/NHSpecificTest/NH3487/Mappings.hbm.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2" assembly="NHibernate.Test" namespace="NHibernate.Test.NHSpecificTest.NH3487">
+
+	<class name="Entity">
+		<composite-id name="Id">
+			<key-property name="Id" />
+		</composite-id>
+		<property name="Name" not-null="true" />
+	</class>
+
+</hibernate-mapping>

src/NHibernate.Test/NHibernate.Test.csproj

@@ -693,6 +693,8 @@
     <Compile Include="NHSpecificTest\BagWithLazyExtraAndFilter\Fixture.cs" />
     <Compile Include="Linq\ByMethod\DistinctTests.cs" />
     <Compile Include="Component\Basic\ComponentWithUniqueConstraintTests.cs" />
+    <Compile Include="NHSpecificTest\NH3487\Entity.cs" />
+    <Compile Include="NHSpecificTest\NH3487\Fixture.cs" />
     <Compile Include="NHSpecificTest\NH3620\Fixture.cs" />
     <Compile Include="NHSpecificTest\NH3620\TwoBlobs.cs" />
     <Compile Include="NHSpecificTest\NH3455\Address.cs" />
@@ -3068,6 +3070,7 @@
     <EmbeddedResource Include="Unionsubclass\DatabaseKeyword.hbm.xml" />
     <EmbeddedResource Include="NHSpecificTest\NH1082\Mappings.hbm.xml" />
     <EmbeddedResource Include="NHSpecificTest\NH3571\Mappings.hbm.xml" />
+    <EmbeddedResource Include="NHSpecificTest\NH3487\Mappings.hbm.xml" />
     <EmbeddedResource Include="NHSpecificTest\NH2692\Mappings.hbm.xml">
       <SubType>Designer</SubType>
     </EmbeddedResource>

src/NHibernate/Tuple/EntityModeToTuplizerMapping.cs

@@ -1,28 +1,43 @@
 using System;
 using System.Collections.Generic;
+using System.Runtime.Serialization;
 using NHibernate.Util;
 
 namespace NHibernate.Tuple
 {
 	/// <summary> Centralizes handling of <see cref="EntityMode"/> to <see cref="ITuplizer"/> mappings. </summary>
 	[Serializable]
-	public abstract class EntityModeToTuplizerMapping
+	public abstract class EntityModeToTuplizerMapping : IDeserializationCallback
 	{
+
 		// NH-1660
-		private readonly IDictionary<EntityMode, ITuplizer> tuplizers
-												= new LinkedHashMap<EntityMode, ITuplizer>(5, new EntityModeEqualityComparer());
+		private readonly IDictionary<EntityMode, ITuplizer> _tuplizers
+			= new LinkedHashMap<EntityMode, ITuplizer>(5, new EntityModeEqualityComparer());
+
+		/// <summary>
+		/// This class might get called during serialization, and may therefore need to deserialize on-demand.
+		/// </summary>
+		[NonSerialized] private bool _isFullyDeserialized;
+
+
+		protected EntityModeToTuplizerMapping()
+		{
+			_isFullyDeserialized = true;
+		}
 
 		protected internal void AddTuplizer(EntityMode entityMode, ITuplizer tuplizer)
 		{
-			tuplizers[entityMode] = tuplizer;
+			EnsureFullyDeserialized();
+			_tuplizers[entityMode] = tuplizer;
 		}
 
 		/// <summary> Given a supposed instance of an entity/component, guess its entity mode. </summary>
 		/// <param name="obj">The supposed instance of the entity/component.</param>
 		/// <returns> The guessed entity mode. </returns>
 		public virtual EntityMode? GuessEntityMode(object obj)
 		{
-			foreach (KeyValuePair<EntityMode, ITuplizer> entry in tuplizers)
+			EnsureFullyDeserialized();
+			foreach (KeyValuePair<EntityMode, ITuplizer> entry in _tuplizers)
 			{
 				ITuplizer tuplizer = entry.Value;
 				if (tuplizer.IsInstance(obj))
@@ -41,8 +56,9 @@ protected internal void AddTuplizer(EntityMode entityMode, ITuplizer tuplizer)
 		/// <returns> The tuplizer, or null if not found. </returns>
 		public virtual ITuplizer GetTuplizerOrNull(EntityMode entityMode)
 		{
+			EnsureFullyDeserialized();
 			ITuplizer result;
-			tuplizers.TryGetValue(entityMode, out result);
+			_tuplizers.TryGetValue(entityMode, out result);
 			return result;
 		}
 
@@ -65,5 +81,19 @@ public virtual ITuplizer GetTuplizer(EntityMode entityMode)
 			}
 			return tuplizer;
 		}
+
+		private void EnsureFullyDeserialized()
+		{
+			if (!_isFullyDeserialized)
+			{
+				((IDeserializationCallback) this).OnDeserialization(this);
+			}
+		}
+
+		void IDeserializationCallback.OnDeserialization(object sender)
+		{
+			((IDeserializationCallback) _tuplizers).OnDeserialization(sender);
+			_isFullyDeserialized = true;
+		}
 	}
 }

src/NHibernate/Util/LinkedHashMap.cs

@@ -2,6 +2,7 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Diagnostics;
+using System.Runtime.Serialization;
 using System.Text;
 using NHibernate.DebugHelpers;
 
@@ -18,7 +19,7 @@ namespace NHibernate.Util
 	/// </remarks>
 	[DebuggerTypeProxy(typeof(CollectionProxy<>))]
 	[Serializable]
-	public class LinkedHashMap<TKey, TValue> : IDictionary<TKey, TValue>
+	public class LinkedHashMap<TKey, TValue> : IDictionary<TKey, TValue>, IDeserializationCallback
 	{
 		[Serializable]
 		protected class Entry
@@ -359,6 +360,11 @@ private bool RemoveImpl(TKey key)
 			return result;
 		}
 
+		void IDeserializationCallback.OnDeserialization(object sender)
+		{
+			((IDeserializationCallback)entries).OnDeserialization(sender);
+		}
+
 		#region System.Object Members
 
 		public override string ToString()